Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate failing pummel/test-policy-integrity on win10-COMPILED_BY-vs2019 #40694

Closed
Trott opened this issue Nov 1, 2021 · 2 comments
Closed

investigate failing pummel/test-policy-integrity on win10-COMPILED_BY-vs2019 #40694

Trott opened this issue Nov 1, 2021 · 2 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. policy Issues and PRs related to the policy subsystem.

Comments

@Trott
Copy link
Member

Trott commented Nov 1, 2021

  • Test: pummel/test-policy-integrity
  • Platform: win10-COMPILED_BY-vs2019
  • Console Output:
07:37:22 not ok 792 pummel/test-policy-integrity
07:37:22   ---
07:37:22   duration_ms: 722.132
07:37:22   severity: fail
07:37:22   exitcode: 1
07:37:22   stack: |-
07:37:22     timeout
07:37:22   ...
@Trott Trott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. policy Issues and PRs related to the policy subsystem. labels Nov 1, 2021
Trott added a commit to Trott/io.js that referenced this issue Nov 1, 2021
@Trott
test: mark test-policy-integrity flaky on Windows
eba1397 
Ref: nodejs#40694
Trott added a commit that referenced this issue Nov 1, 2021
@Trott
test: mark test-policy-integrity flaky on Windows
b2aff85 
Ref: #40694

PR-URL: #40684
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
targos pushed a commit that referenced this issue Nov 4, 2021
@Trott @targos
test: mark test-policy-integrity flaky on Windows
8226690 
Ref: #40694

PR-URL: #40684
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
targos pushed a commit that referenced this issue Nov 6, 2021
@Trott @targos
test: mark test-policy-integrity flaky on Windows
5020f63 
Ref: #40694

PR-URL: #40684
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
@joyeecheung
Copy link
Member

It seems sequential/test-child-process-pass-fd has also been timing out on Windows together with this (e.g. https://ci.nodejs.org/job/node-test-binary-windows-js-suites/12136). Maybe it should be marked as flaky also?

@Trott
Copy link
Member Author

Trott commented Nov 8, 2021

@nodejs/testing @nodejs/platform-windows Is anyone able to investigate this a little bit more closely?

Trott added a commit to Trott/io.js that referenced this issue Nov 9, 2021
@Trott
test: fix flaky test-policy-integrity
29fdfb3 
Split the test into three tests so that it doesn't time out.

Fixes: nodejs#40694
Fixes: nodejs#38088
Trott added a commit to Trott/io.js that referenced this issue Nov 9, 2021
@Trott
test: fix flaky test-policy-integrity
d88cb01 
Split the test into three tests so that it doesn't time out.

Fixes: nodejs#40694
Fixes: nodejs#38088
@Trott Trott mentioned this issue Nov 9, 2021
Closed
Trott added a commit to Trott/io.js that referenced this issue Nov 9, 2021
@Trott
test: fix flaky test-policy-integrity
eea1cc9 
Split the test into seven tests so that it doesn't time out.

Fixes: nodejs#40694
Fixes: nodejs#38088
@Trott Trott closed this as completed in fc4a792 Nov 10, 2021
targos pushed a commit that referenced this issue Nov 21, 2021
@Trott @targos
test: fix flaky test-policy-integrity
3d89623 
Split the test into seven tests so that it doesn't time out.

Fixes: #40694
Fixes: #38088

PR-URL: #40763
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
danielleadams pushed a commit that referenced this issue Jan 30, 2022
@Trott @danielleadams
test: fix flaky test-policy-integrity
aef6def 
Split the test into seven tests so that it doesn't time out.

Fixes: #40694
Fixes: #38088

PR-URL: #40763
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
danielleadams pushed a commit that referenced this issue Feb 1, 2022
@Trott @danielleadams
test: fix flaky test-policy-integrity
25a166d 
Split the test into seven tests so that it doesn't time out.

Fixes: #40694
Fixes: #38088

PR-URL: #40763
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. policy Issues and PRs related to the policy subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky test-policy-integrity Trott/io.js
2 participants
@Trott @joyeecheung