Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Symbol.for in Node-API #41294

Closed
Brooooooklyn opened this issue Dec 23, 2021 · 4 comments
Closed

Add Symbol.for in Node-API #41294

Brooooooklyn opened this issue Dec 23, 2021 · 4 comments
Labels
feature request Issues that request new features to be added to Node.js. node-api Issues and PRs related to the Node-API.

Comments

@Brooooooklyn
Copy link

Is your feature request related to a problem? Please describe.

Add Symbol.for support in Node-API

Describe the solution you'd like

napi_status napi_create_symbol_for(napi_env env, const char* key, napi_value* result)

Ref: pola-rs/polars#1703 (comment)
@Brooooooklyn Brooooooklyn added the feature request Issues that request new features to be added to Node.js. label Dec 23, 2021
@Trott
Copy link
Member

Trott commented Dec 23, 2021

@nodejs/node-api

@Mesteery Mesteery added the node-api Issues and PRs related to the Node-API. label Dec 23, 2021
@JckXia
Copy link
Member

JckXia commented Dec 24, 2021

I am interested in taking a look! We currently have support for Symbol.For in node-addon-api, but I am not sure if it fits the use-cases here.

RaisinTen added a commit to RaisinTen/node that referenced this issue Dec 26, 2021
@RaisinTen
src: add napi_create_symbol_for()
9d3dc30 
Fixes: nodejs#41294

Signed-off-by: Darshan Sen <darshan.sen@postman.com>
@RaisinTen RaisinTen mentioned this issue Dec 26, 2021
Closed
@RaisinTen
Copy link
Contributor

PR: #41329

RaisinTen added a commit to RaisinTen/node that referenced this issue Jan 2, 2022
@RaisinTen
node-api: add node_api_symbol_for()
4d2dc48 
Fixes: nodejs#41294

Signed-off-by: Darshan Sen <darshan.sen@postman.com>
RaisinTen added a commit to RaisinTen/node that referenced this issue Jan 8, 2022
@RaisinTen
node-api: add node_api_symbol_for()
7899fdb 
Fixes: nodejs#41294

Signed-off-by: Darshan Sen <darshan.sen@postman.com>
@targos targos moved this to Pending triage in Node.js feature requests Jan 16, 2022
@targos targos moved this from Pending triage to In Progress in Node.js feature requests Jan 16, 2022
RaisinTen added a commit to RaisinTen/node that referenced this issue Jan 23, 2022
@RaisinTen
node-api: add node_api_symbol_for()
3d896f9 
Fixes: nodejs#41294

Signed-off-by: Darshan Sen <raisinten@gmail.com>
@targos targos moved this from In Progress to Done in Node.js feature requests Jan 28, 2022
Linkgoron pushed a commit to Linkgoron/node that referenced this issue Jan 31, 2022
@RaisinTen @Linkgoron
node-api: add node_api_symbol_for()
31a9448 
Fixes: nodejs#41294

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: nodejs#41329
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno pushed a commit that referenced this issue Feb 8, 2022
@RaisinTen @ruyadorno
node-api: add node_api_symbol_for()
2cae994 
Fixes: #41294

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #41329
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jbuilds
Copy link

jbuilds commented Mar 30, 2022

Good bye

danielleadams pushed a commit to danielleadams/node that referenced this issue Apr 21, 2022
@RaisinTen @danielleadams
node-api: add node_api_symbol_for()
11ec334 
Fixes: nodejs#41294

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: nodejs#41329
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

node-api: add node_api_symbol_for() RaisinTen/node
6 participants
@Trott @Brooooooklyn @JckXia @RaisinTen @Mesteery @jbuilds