Reduce the number of patches we float on V8

[targos]

We should aim for 0 floating patches from our side (except cherry-picks of commits that landed upstream).

Here's the list of everything that we currently float on top of V8 10.7:

• deps: V8: forward declaration of Rtl*FunctionTable
  I don't remember why we have this one. It's quite old, so I opened a PR trying to revert it.
• deps: fix V8 build issue with inline methods
  This bundles 4 fixes related to inline methods with Windows/MSVC. I think we would actually need a 5th one to fix the MSVC build with Visual Studio 2022 (windows build start failed on main caused by MSVC update #43092).
  Ideally we would upstream the necessary fixes but I don't know enough of C++/Windows to open a CL that the V8 team would accept.
• deps: V8: fix v8-cppgc.h for MSVC
  Not sure why this wasn't submitted upstream.
  Revert tentative: deps: V8: add explicit constructor to CppHeapCreateParams #45700
  Now fixed upstream in https://chromium-review.googlesource.com/c/v8/v8/+/3533019
• deps: make V8 compilable with older glibc
  Can we remove this one now? PR: Revert "deps: make V8 compilable with older glibc" #45162
• deps: silence irrelevant V8 warning
  I often have to do this kind of patches. The problem is that if we keep the deprecation, V8's own headers trigger it and the build fails because of -Werror. There's probably a better way to handle it but I don't know it.
• deps: fix V8 build on SmartOS
  Still waiting for SmartOS people to upstream the fix. (Build error on SmartOS node-v8#239)
  Fixed upstream in https://chromium-review.googlesource.com/c/v8/v8/+/4026402
• deps: fix V8 build on Windows with MSVC
  Don't know what do to about this one. See discussion in Build error on Windows node-v8#235

@nodejs/v8-update

[gengjiawen]

deps: V8: fix v8-cppgc.h for MSVC
Not sure why this wasn't submitted upstream.

I know this. I send the patch, but v8 team want it to be compatible with cpp20, so it got stuck

[bnoordhuis]

"make V8 compilable with older glibc" can be dropped, "silence irrelevant V8 warning" can be dropped if we turn off -Werror.

W.r.t. the msvc patches: maybe we should just switch to clang-cl? We'll want V8's headers to be usable by msvc (for add-ons) but that's a lot less work than keeping V8 itself buildable under msvc.

[targos]

W.r.t. the msvc patches: maybe we should just switch to clang-cl?

Let me rebase #35433 to see how it goes.

[targos]

/cc @richardlau who added -Werror in fcc183c

[richardlau]

/cc @richardlau who added -Werror in fcc183c

fcc183c was a follow on to #32685 where the original request to enable -Werror came from. I think this may have been a request from Red Hat (prior to me transferring over from IBM).
cc @danbev

[mhdawson]

In terms of -Werror, is the suggestion to turn it off just for V8 or for all of Node.js. I'd be ok with turning it off for deps like v8, but would want us to keep it for our code.

[targos]

In terms of -Werror, is the suggestion to turn it off just for V8 or for all of Node.js. I'd be ok with turning it off for deps like v8, but would want us to keep it for our code.

I'm all for it, but I don't know how to set that up.

[bnoordhuis]

is the suggestion to turn it off just for V8 or for all of Node.js

For dependencies, like V8, since we don't control those.

-Werror can stay for node itself (on CI - it's anti-social to impose that on people building node from source.)

[richardlau]

I've reminded myself of how we set this up -- we already only turn on (in the CI through the --error-on-warn configure option) -Werror for node itself and not for dependencies. The issue here is that the warning is coming from a V8 header file so the node part of the build errors out when including v8.h.

[targos]

@Flarna It's not obvious what your edit changed (apart from removing the first check)

[Flarna]

Actually I didn't want to change anything. Whatever was done by me here was per accident. Sorry

[gengjiawen]

deps: V8: fix v8-cppgc.h for MSVC
Not sure why this wasn't submitted upstream.

I know this. I send the patch, but v8 team want it to be compatible with cpp20, so it got stuck

I will give another try after MSVC fix landed #45427 (comment)

[bnoordhuis]

deps: fix V8 build issue with inline methods and deps: fix V8 build on Windows with MSVC stand a good chance of being fixed by nodejs/node-v8@691f1c4.

(That whole class of compile-time trouble is likely going away now.)