Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http.IncomingMessage isn't labeled as a class #4576

Closed
Sequoia opened this issue Jan 8, 2016 · 3 comments
Closed

http.IncomingMessage isn't labeled as a class #4576

Sequoia opened this issue Jan 8, 2016 · 3 comments
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.

Comments

@Sequoia
Copy link
Contributor

Sequoia commented Jan 8, 2016

https://nodejs.org/api/http.html

http.ServerResponse, http.Server and http.ClientRequest are labelled as classes. I reckon IncomingMessage ought to be as well. 🐄
@cjihrig
Copy link
Contributor

cjihrig commented Jan 8, 2016

Care to make a PR?

@mscdex mscdex added http Issues or PRs related to the http subsystem. doc Issues and PRs related to the documentations. labels Jan 8, 2016
@Sequoia
Copy link
Contributor Author

Sequoia commented Jan 8, 2016

Oh sure! Sorry I didn't know the docs were in this repo (the about these docs page doesn't mention it). I'll try to get that to if I can!

@Sequoia
Copy link
Contributor Author

Sequoia commented Jan 8, 2016

I mean to say it doesn't link here. On closer inspection I see that it states that the docs are in the source quit plainly!

@Sequoia Sequoia mentioned this issue Jan 8, 2016
Closed
MylesBorins pushed a commit that referenced this issue Jan 11, 2016
@Sequoia
doc: label http.IncomingMessage as a Class
6f2e28a 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: #4589
Fixes: #4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this issue Jan 12, 2016
@Sequoia
doc: label http.IncomingMessage as a Class
fdfc72c 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: #4589
Fixes: #4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this issue Jan 13, 2016
@Sequoia
doc: label http.IncomingMessage as a Class
367a13d 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: #4589
Fixes: #4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this issue Jan 14, 2016
@Sequoia
doc: label http.IncomingMessage as a Class
f2fa2d3 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: #4589
Fixes: #4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this issue Jan 14, 2016
@Sequoia
doc: label http.IncomingMessage as a Class
70791ae 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: #4589
Fixes: #4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this issue Jan 19, 2016
@Sequoia
doc: label http.IncomingMessage as a Class
bd31740 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: #4589
Fixes: #4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
scovetta pushed a commit to scovetta/node that referenced this issue Apr 2, 2016
@Sequoia
doc: label http.IncomingMessage as a Class
ac96253 
`Server`, `ServerResponse` etc. were marked as classes, this one class
was overlooked.

PR-URL: nodejs#4589
Fixes: nodejs#4576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mscdex @Sequoia @cjihrig