Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return opaque origin for blob: URL containing inner non-http(s): URL #48157

Closed
annevk opened this issue May 24, 2023 · 3 comments
Closed

Return opaque origin for blob: URL containing inner non-http(s): URL #48157

annevk opened this issue May 24, 2023 · 3 comments
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@annevk
Copy link

annevk commented May 24, 2023

See whatwg/url#771 for the URL Standard change and web-platform-tests/wpt#40133 for tests.

@aduh95 aduh95 added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label May 24, 2023
@aduh95
Copy link
Contributor

aduh95 commented May 24, 2023

@nodejs/url

@hemanth
Copy link
Contributor

hemanth commented May 25, 2023

I would like to take a stab at this.

From what I understand is it just the below in url.js ?

if(out.protocol !== 'https') {
  return null;
}

@anonrig
Copy link
Member

anonrig commented May 25, 2023

Since we are not using Ada's origin getter, we don't need to update Ada to close this issue. But regardless, I've fixed the Ada origin-getter and will release a new version as soon as it gets a review from @lemire. I've also left some comments on @hemanth's pull request. After the comments are addressed we can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@hemanth @annevk @anonrig @aduh95 and others