Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominating @vmoroz as a collaborator #48388

Closed
gabrielschulhof opened this issue Jun 8, 2023 · 6 comments
Closed

Nominating @vmoroz as a collaborator #48388

gabrielschulhof opened this issue Jun 8, 2023 · 6 comments
Labels
meta Issues and PRs related to the general management of the project. node-api Issues and PRs related to the Node-API.

Comments

@gabrielschulhof
Copy link
Contributor

@vmoroz has been an active participant in Node-API and a regular attendee to our meetings for multiple years, and has contributed significantly to its maintenance, especially in the area of references and add-on registration.

@nodejs/collaborators

@legendecas
Copy link
Member

Vladimir has made significant contributions to Node-API. I strongly support the nomination!

@mhdawson
Copy link
Member

mhdawson commented Jun 8, 2023

+1 from me as well. His experience and contribution to Node-API both in nodejs/core and nodejs/node-add-api as well as the weekly discussions have been very valuable.

@gabrielschulhof gabrielschulhof added the node-api Issues and PRs related to the Node-API. label Jun 8, 2023
@debadree25 debadree25 added the meta Issues and PRs related to the general management of the project. label Jun 8, 2023
@mhdawson
Copy link
Member

I'll co-ordinate a time next week @vmoroz to onboard him.

@mhdawson
Copy link
Member

We've planned to do onboarding 2-3 ET on Thursday the 22nd. @nodejs/tsc if anybody else wants to join in to help just let me know.

@MoLow
Copy link
Member

MoLow commented Jun 20, 2023

I might be available to join

@mhdawson
Copy link
Member

@MoLow sorry I missed your comment, should have checked earlier :(

RafaelGSS pushed a commit that referenced this issue Jul 3, 2023
PR-URL: #48527
Fixes: #48388
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
PR-URL: nodejs#48527
Fixes: nodejs#48388
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
PR-URL: nodejs#48527
Fixes: nodejs#48388
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
ruyadorno pushed a commit that referenced this issue Sep 10, 2023
PR-URL: #48527
Fixes: #48388
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
ruyadorno pushed a commit that referenced this issue Sep 13, 2023
PR-URL: #48527
Fixes: #48388
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project. node-api Issues and PRs related to the Node-API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants