Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loaders: globalPreload warning is incorrect #49026

Closed
cjihrig opened this issue Aug 5, 2023 · 0 comments · Fixed by #49069
Closed

loaders: globalPreload warning is incorrect #49026

cjihrig opened this issue Aug 5, 2023 · 0 comments · Fixed by #49069
Labels
esm Issues and PRs related to the ECMAScript Modules implementation.

Comments

@cjihrig
Copy link
Contributor

cjihrig commented Aug 5, 2023

Version

main

Platform

all

Subsystem

esm

What steps will reproduce the bug?

Use the globalPreload hook.

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior? Why is that the expected behavior?

globalPreload is being removed. The error message should reflect that correctly.

What do you see instead?

(node:9201) ExperimentalWarning: `globalPreload` will be removed in a future version. Please use `initialize` instead. is an experimental feature and might change at any time

This arguably should not be an experimental warning, because it is about something being removed. The text of the warning is definitely incorrect though.

Additional information

No response
@aduh95 aduh95 mentioned this issue Aug 8, 2023
Merged
@VoltrexKeyva VoltrexKeyva added the esm Issues and PRs related to the ECMAScript Modules implementation. label Aug 9, 2023
nodejs-github-bot pushed a commit that referenced this issue Aug 13, 2023
@aduh95
esm: fix globalPreload warning
b5da2f4 
PR-URL: #49069
Fixes: #49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
@aduh95 @Ceres6
esm: fix globalPreload warning
54b72f6 
PR-URL: nodejs#49069
Fixes: nodejs#49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
RafaelGSS pushed a commit that referenced this issue Aug 15, 2023
@aduh95 @RafaelGSS
esm: fix globalPreload warning
87dd150 
PR-URL: #49069
Fixes: #49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
RafaelGSS pushed a commit to RafaelGSS/node that referenced this issue Aug 15, 2023
@aduh95 @RafaelGSS
esm: fix globalPreload warning
8179751 
PR-URL: nodejs#49069
Fixes: nodejs#49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
rluvaton pushed a commit to rluvaton/node that referenced this issue Aug 15, 2023
@aduh95 @rluvaton
esm: fix globalPreload warning
d899145 
PR-URL: nodejs#49069
Fixes: nodejs#49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
RafaelGSS pushed a commit that referenced this issue Aug 16, 2023
@aduh95 @RafaelGSS
esm: fix globalPreload warning
5016523 
PR-URL: #49069
Fixes: #49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
RafaelGSS pushed a commit that referenced this issue Aug 17, 2023
@aduh95 @RafaelGSS
esm: fix globalPreload warning
31442b9 
PR-URL: #49069
Fixes: #49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
targos pushed a commit to targos/node that referenced this issue Nov 11, 2023
@aduh95 @targos
esm: fix globalPreload warning
8ec3953 
PR-URL: nodejs#49069
Fixes: nodejs#49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
targos pushed a commit that referenced this issue Nov 23, 2023
@aduh95 @targos
esm: fix globalPreload warning
01ca6d2 
PR-URL: #49069
Backport-PR-URL: #50669
Fixes: #49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
@sercher
esm: fix globalPreload warning
8f2d402 
PR-URL: nodejs/node#49069
Backport-PR-URL: nodejs/node#50669
Fixes: nodejs/node#49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
@sercher
esm: fix globalPreload warning
50c10ac 
PR-URL: nodejs/node#49069
Backport-PR-URL: nodejs/node#50669
Fixes: nodejs/node#49026
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
esm Issues and PRs related to the ECMAScript Modules implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

esm: fix globalPreload warning aduh95/node
2 participants
@cjihrig @VoltrexKeyva