Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

es-module/test-loaders-workers-spawned is flaky #50247

Closed
anonrig opened this issue Oct 18, 2023 · 0 comments · Fixed by #50251
Closed

es-module/test-loaders-workers-spawned is flaky #50247

anonrig opened this issue Oct 18, 2023 · 0 comments · Fixed by #50251
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. macos Issues and PRs related to the macOS platform / OSX.

Comments

@anonrig
Copy link
Member

anonrig commented Oct 18, 2023

Test

es-module/test-loaders-workers-spawned

Platform

macOS x64

Console output

✖ failing tests:

test at file:/Users/runner/work/node/node/test/es-module/test-loaders-workers-spawned.mjs:37:3
✖ should support --require and --import along with using a loader written in CJS and CJS entry point (225.582869ms)
  AssertionError [ERR_ASSERTION]: The input did not match the regular expression /^A\r?\nA\r?\n(B\r?\nC|C\r?\nB)\r?\nD\r?\n$/. Input:
  
  'A\nC\nA\nB\nD\n'
  
      at TestContext.<anonymous> (file:///Users/runner/work/node/node/test/es-module/test-loaders-workers-spawned.mjs:52:12)
      at async Test.run (node:internal/test_runner/test:632:9)
      at async Promise.all (index 2)
      at async Suite.run (node:internal/test_runner/test:948:7)
      at async startSubtest (node:inte

Build links

Additional information

No response
@anonrig anonrig added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Oct 18, 2023
@github-actions github-actions bot added the macos Issues and PRs related to the macOS platform / OSX. label Oct 18, 2023
anonrig added a commit to anonrig/node that referenced this issue Oct 18, 2023
@anonrig
test: set test-loaders-workers-spawned as flaky
30598a5 
Ref: nodejs#50247
@anonrig anonrig mentioned this issue Oct 18, 2023
Closed
@aduh95 aduh95 mentioned this issue Oct 18, 2023
Merged
@aduh95 aduh95 closed this as completed in 765339a Oct 19, 2023
targos pushed a commit that referenced this issue Oct 23, 2023
@aduh95 @targos
test: deflake test-loaders-workers-spawned
317e447 
PR-URL: #50251
Fixes: #50247
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
alexfernandez pushed a commit to alexfernandez/node that referenced this issue Nov 1, 2023
@aduh95 @alexfernandez
test: deflake test-loaders-workers-spawned
a0ae8ce 
PR-URL: nodejs#50251
Fixes: nodejs#50247
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit to targos/node that referenced this issue Nov 11, 2023
@aduh95 @targos
test: deflake test-loaders-workers-spawned
fb2adef 
PR-URL: nodejs#50251
Fixes: nodejs#50247
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit to targos/node that referenced this issue Nov 11, 2023
@aduh95 @targos
test: deflake test-loaders-workers-spawned
8605b41 
PR-URL: nodejs#50251
Fixes: nodejs#50247
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this issue Nov 11, 2023
@aduh95 @targos
test: deflake test-loaders-workers-spawned
5c56081 
PR-URL: #50251
Fixes: #50247
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit to targos/node that referenced this issue Nov 11, 2023
@aduh95 @targos
test: deflake test-loaders-workers-spawned
bd6512e 
PR-URL: nodejs#50251
Fixes: nodejs#50247
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this issue Nov 23, 2023
@aduh95 @targos
test: deflake test-loaders-workers-spawned
c1a8ae3 
PR-URL: #50251
Backport-PR-URL: #50669
Fixes: #50247
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
@sercher
test: deflake test-loaders-workers-spawned
9de29ed 
PR-URL: nodejs/node#50251
Backport-PR-URL: nodejs/node#50669
Fixes: nodejs/node#50247
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
@sercher
test: deflake test-loaders-workers-spawned
48da608 
PR-URL: nodejs/node#50251
Backport-PR-URL: nodejs/node#50669
Fixes: nodejs/node#50247
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. macos Issues and PRs related to the macOS platform / OSX.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix test-loaders-workers-spawned flakiness aduh95/node
1 participant
@anonrig