-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate flaky test-tls-session-cache #5111
Comments
Here's the output if it helps anyone debug:
@nodejs/testing @nodejs/crypto |
Is smartos the only affected platform? If yes, mark it flaky for that platform and let's move on. |
It does appear that it is only SmartOS and it also appears to be a network-related bug in SmartOS that we've had to work around elsewhere. I'll try to put together a PR to fix it, but if that fails, yeah, mark as flaky... /cc @nodejs/platform-solaris |
Proposed workaround: #7505 |
Sometimes, a SmartOS bug results in ECONNREFUSED when trying to connect to the TLS server that the test starts. Retry in that situation. Fixes: nodejs#5111 Refs: https://smartos.org/bugview/OS-2767
Sometimes, a SmartOS bug results in ECONNREFUSED when trying to connect to the TLS server that the test starts. Retry in that situation. Fixes: #5111 Refs: https://smartos.org/bugview/OS-2767 PR-URL: #7505 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Example failure:
The text was updated successfully, but these errors were encountered: