tests: tools/node_modules is not present in tarball

[AdamMajer]

Version

No response

Platform

No response

Subsystem

No response

What steps will reproduce the bug?

No response

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior? Why is that the expected behavior?

No response

What do you see instead?

In git repository there is

https://github.com/nodejs/node/tree/main/tools/node_modules

in the source tarball, there is nothing there. This breaks at least

https://github.com/nodejs/node/blob/main/benchmark/misc/startup-cli-version.js#L13

Additional information

No response

[AdamMajer]

Seems this is kind of test regression introduced in #50684 where this tests relies on this removed tool. tools/node_modules are removed from the tarball for some time, meaning many years.

[richardlau]

Ideally this should have been caught by the https://github.com/nodejs/node/blob/main/.github/workflows/build-tarball.yml workflow in #50684 but it was not 😞.

[AdamMajer]

      - name: Copy directories needed for testing
        run: |
          cp -r tools/node_modules $TAR_DIR/tools
          cp -r tools/eslint-rules $TAR_DIR/tools

this seems to copy things over 🤔 I think either these should be then shipped or should not be needed for tests?

[targos]

I'm not sure it's reasonable to expect that benchmarks and their tests work with the release tarball.

[AdamMajer]

Well, it's been working since at least nodejs 4.x 😉 I'm happy if tools/node_modules is removed in tarball, but there is no package-lock.json that allows it to be installed again. This removed part of tarball is about 22MB of disk space.

The tools/eslint-rules are only 100kB so this can be added to the tarball.