Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parallel/test-http-chunk-extensions-limit is flaky #51883

Closed
joyeecheung opened this issue Feb 26, 2024 · 0 comments · Fixed by #51943
Closed

parallel/test-http-chunk-extensions-limit is flaky #51883

joyeecheung opened this issue Feb 26, 2024 · 0 comments · Fixed by #51943
Assignees
@Ethan-Arrowood
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem.

Comments

@joyeecheung
Copy link
Member

Reason parallel/test-http-chunk-extensions-limit
Type JS_TEST_FAILURE
Failed PR 7 (https://github.com/nodejs/node/pull/51842/, https://github.com/nodejs/node/pull/51841/, https://github.com/nodejs/node/pull/51852/, https://github.com/nodejs/node/pull/51859/, https://github.com/nodejs/node/pull/51863/, https://github.com/nodejs/node/pull/51865/, https://github.com/nodejs/node/pull/51808/)
Appeared test-ibm-aix72-ppc64_be-1, test-osuosl-aix72-ppc64_be-2, test-osuosl-aix72-ppc64_be-3
First CI https://ci.nodejs.org/job/node-test-pull-request/57325/
Last CI https://ci.nodejs.org/job/node-test-pull-request/57410/
Example 
not ok 1338 parallel/test-http-chunk-extensions-limit
  ---
  duration_ms: 845.13100
  severity: fail
  exitcode: 1
  stack: |-
    node:events:497
          throw er; // Unhandled 'error' event
          ^
    
    Error: read ECONNRESET
        at TCP.onStreamRead (node:internal/stream_base_commons:217:20)
    Emitted 'error' event on Socket instance at:
        at emitErrorNT (node:internal/streams/destroy:169:8)
        at emitErrorCloseNT (node:internal/streams/destroy:128:3)
        at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
      errno: -73,
      code: 'ECONNRESET',
      syscall: 'read'
    }
    
    Node.js v22.0.0-pre
  ...

Refs: nodejs/reliability#794

This has failed 7 PRs out of the recent 100 CIs. Looking at the reliability report it seems to have been flaky since it landed after the security release.

cc @ShogunPanda @mcollina @RafaelGSS @marco-ippolito from the original PR
@joyeecheung joyeecheung added http Issues or PRs related to the http subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Feb 26, 2024
@Ethan-Arrowood Ethan-Arrowood self-assigned this Feb 28, 2024
@Ethan-Arrowood Ethan-Arrowood mentioned this issue Mar 1, 2024
Merged
Ethan-Arrowood added a commit to Ethan-Arrowood/node that referenced this issue Mar 1, 2024
@Ethan-Arrowood
test: fix flaky http-chunk-extensions-limit test
4375a83 
Replace the setInterval with a queueMicrotask to make test less flaky.

Fixes: nodejs#51883
Ethan-Arrowood added a commit to Ethan-Arrowood/node that referenced this issue Mar 1, 2024
@Ethan-Arrowood
test: fix flaky http-chunk-extensions-limit test
fcc6a67 
Replace the setInterval with a queueMicrotask to make test less flaky.

Fixes: nodejs#51883
PR-URL: nodejs#51943
nodejs-github-bot pushed a commit that referenced this issue Mar 3, 2024
@Ethan-Arrowood
test: fix flaky http-chunk-extensions-limit test
a8f281f 
Replace the setInterval with a queueMicrotask to make test less flaky.

Fixes: #51883
PR-URL: #51943
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
targos pushed a commit that referenced this issue Mar 7, 2024
@Ethan-Arrowood @targos
test: fix flaky http-chunk-extensions-limit test
57ba8f5 
Replace the setInterval with a queueMicrotask to make test less flaky.

Fixes: #51883
PR-URL: #51943
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
richardlau pushed a commit that referenced this issue Mar 8, 2024
@Ethan-Arrowood @richardlau
test: fix flaky http-chunk-extensions-limit test
902d8b3 
Replace the setInterval with a queueMicrotask to make test less flaky.

Fixes: #51883
PR-URL: #51943
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
richardlau pushed a commit that referenced this issue Mar 25, 2024
@Ethan-Arrowood @richardlau
test: fix flaky http-chunk-extensions-limit test
eea738e 
Replace the setInterval with a queueMicrotask to make test less flaky.

Fixes: #51883
PR-URL: #51943
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
richardlau pushed a commit that referenced this issue Mar 25, 2024
@Ethan-Arrowood @richardlau
test: fix flaky http-chunk-extensions-limit test
0ad88f6 
Replace the setInterval with a queueMicrotask to make test less flaky.

Fixes: #51883
PR-URL: #51943
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
rdw-msft pushed a commit to rdw-msft/node that referenced this issue Mar 26, 2024
@Ethan-Arrowood @rdw-msft
test: fix flaky http-chunk-extensions-limit test
7d9e323 
Replace the setInterval with a queueMicrotask to make test less flaky.

Fixes: nodejs#51883
PR-URL: nodejs#51943
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ethan-Arrowood Ethan-Arrowood

Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky http-chunk-extensions-limit test Ethan-Arrowood/node
2 participants
@joyeecheung @Ethan-Arrowood