Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nominating @StefanStojanovic to be a collaborator #52929

Closed
joyeecheung opened this issue May 10, 2024 · 8 comments
Closed

Nominating @StefanStojanovic to be a collaborator #52929

joyeecheung opened this issue May 10, 2024 · 8 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@joyeecheung
Copy link
Member

joyeecheung commented May 10, 2024 •
edited
Loading

@StefanStojanovic has been doing a great job in improving Windows support for the project, both in core and in the build working group.

Commits authored on nodejs/node: github.com/nodejs/node/commits?author=StefanStojanovic
Pull requests opened: github.com/search?q=author:StefanStojanovic+org:nodejs&type=pullrequests
Issues opened: github.com/search?q=author:StefanStojanovic+org:nodejs&type=issues
Comments on pull requests and issues throughout the Node.js organization: https://github.com/search?q=commenter%3AStefanStojanovic+org%3Anodejs&type=pullrequests
@benjamingr
Copy link
Member

+1

@VoltrexKeyva VoltrexKeyva added the meta Issues and PRs related to the general management of the project. label May 10, 2024
@VoltrexKeyva
Copy link
Member

Pinging @nodejs/collaborators for collaborator nomination.

As documented by the governance document

@sxa
Copy link
Member

sxa commented May 10, 2024

+1 from me :-)

@mhdawson
Copy link
Member

+1 from me

@H4ad
Copy link
Member

H4ad commented May 10, 2024

+1, he is always helpful with Windows PRs.

@lemire
Copy link
Member

lemire commented May 10, 2024

Oh! He knows about Windows?

+100000

@lukekarrys
Copy link
Member

+1. He has also been very helpful in the node-gyp repo contributing fixes, reviewing PRs, and training issues.

StefanStojanovic added a commit to JaneaSystems/node that referenced this issue May 23, 2024
@StefanStojanovic
doc: add StefanStojanovic to collaborators
d40c6bd 
Fixes: nodejs#52929
@StefanStojanovic StefanStojanovic mentioned this issue May 23, 2024
Closed
@srl295
Copy link
Member

srl295 commented May 23, 2024

FWIW +1 from me also, excellent interaction

targos pushed a commit that referenced this issue Jun 1, 2024
@StefanStojanovic @targos
doc: add StefanStojanovic to collaborators
db5dd0c 
Fixes: #52929
PR-URL: #53118
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this issue Jun 20, 2024
@StefanStojanovic @eliphazbouye
doc: add StefanStojanovic to collaborators
017956d 
Fixes: nodejs#52929
PR-URL: nodejs#53118
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this issue Jun 22, 2024
@StefanStojanovic @bmeck
doc: add StefanStojanovic to collaborators
d96ff46 
Fixes: nodejs#52929
PR-URL: nodejs#53118
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito pushed a commit that referenced this issue Jul 19, 2024
@StefanStojanovic @marco-ippolito
doc: add StefanStojanovic to collaborators
fbe74b9 
Fixes: #52929
PR-URL: #53118
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito pushed a commit that referenced this issue Jul 19, 2024
@StefanStojanovic @marco-ippolito
doc: add StefanStojanovic to collaborators
5e76c25 
Fixes: #52929
PR-URL: #53118
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add StefanStojanovic to collaborators JaneaSystems/node
9 participants
@lemire @lukekarrys @srl295 @benjamingr @joyeecheung @sxa @mhdawson @H4ad @VoltrexKeyva