Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url.parse result differences in 5.7.x to 5.6.x #5393

Closed
tombell opened this issue Feb 23, 2016 · 2 comments
Closed

url.parse result differences in 5.7.x to 5.6.x #5393

tombell opened this issue Feb 23, 2016 · 2 comments
Labels
confirmed-bug Issues with confirmed bugs. url Issues and PRs related to the legacy built-in url module.
Milestone

Comments

@tombell
Copy link

tombell commented Feb 23, 2016

  • Version: v5.7.0
  • Platform: Darwin Kernel Version 15.3.0: Thu Dec 10 18:40:58 PST 2015; root:xnu-3248.30.4~1/RELEASE_X86_64 x86_64

I updated to Node 5.7.0 today, which results in my Cordova build breaking due to a change in the output of url.parse.

In Node 5.5.0 the output of parsing https://* was the following:

{ protocol: 'https:',
  slashes: true,
  auth: null,
  host: '',
  port: null,
  hostname: '',
  hash: null,
  search: null,
  query: null,
  pathname: '/*',
  path: '/*',
  href: 'https:///*' }

However this changed when updating to 5.7.0:

Url {
  protocol: 'https:',
  slashes: true,
  auth: null,
  host: '',
  port: null,
  hostname: '',
  hash: null,
  search: null,
  query: null,
  pathname: null,
  path: null,
  href: 'https://' }

The pathname being null now broke the Cordova CLI library. Was this change intended to be breaking?

@MylesBorins
Copy link
Contributor

/cc @mscdex

@MylesBorins MylesBorins added the url Issues and PRs related to the legacy built-in url module. label Feb 23, 2016
@Fishrock123
Copy link
Contributor

The pathname being null now broke the Cordova CLI library. Was this change intended to be breaking?

No, though we did have a large path refactor.

mscdex added a commit to mscdex/io.js that referenced this issue Feb 23, 2016
@Fishrock123 Fishrock123 modified the milestone: v5.7.1 Feb 23, 2016
@Fishrock123 Fishrock123 mentioned this issue Feb 23, 2016
3 tasks
@silverwind silverwind added the confirmed-bug Issues with confirmed bugs. label Feb 27, 2016
rvagg pushed a commit that referenced this issue Feb 28, 2016
Fixes: #5393
PR-URL: #5394
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed-bug Issues with confirmed bugs. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Development

No branches or pull requests

4 participants