-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{aborted: false}
is treated as valid AbortSignal
but not in other runtimes
#54962
Labels
abortcontroller
Issues and PRs related to the AbortController API
web-standards
Issues and PRs related to Web APIs
Comments
RedYetiDev
added
abortcontroller
Issues and PRs related to the AbortController API
web-standards
Issues and PRs related to Web APIs
labels
Sep 16, 2024
Can you provide the exact error given by other runtimes? |
In Firefox:
In Chrome:
|
This was a deliberate design choice (to not brand check) in order to have better ecosystem compatibility. Now that we've had AbortSignal for a few years it's fine to revisit |
louwers
pushed a commit
to louwers/node
that referenced
this issue
Nov 2, 2024
PR-URL: nodejs#54965 Fixes: nodejs#54962 Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
louwers
pushed a commit
to louwers/node
that referenced
this issue
Nov 2, 2024
PR-URL: nodejs#54965 Fixes: nodejs#54962 Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this issue
Nov 21, 2024
PR-URL: nodejs#54965 Fixes: nodejs#54962 Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this issue
Nov 21, 2024
PR-URL: nodejs#54965 Fixes: nodejs#54962 Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
abortcontroller
Issues and PRs related to the AbortController API
web-standards
Issues and PRs related to Web APIs
Version
v22.8.0
Platform
Subsystem
abort controller
What steps will reproduce the bug?
How often does it reproduce? Is there a required condition?
100%
What is the expected behavior? Why is that the expected behavior?
Fail with TypeError
What do you see instead?
Passed
Additional information
This fails in other runtime like Chrome and Firefox
The text was updated successfully, but these errors were encountered: