Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unflag node:sqlite #55854

Closed
mcollina opened this issue Nov 14, 2024 · 4 comments · Fixed by #55890
Closed

Unflag node:sqlite #55854

mcollina opened this issue Nov 14, 2024 · 4 comments · Fixed by #55890
Labels
discuss Issues opened for discussions and feedbacks. experimental Issues and PRs related to experimental features. sqlite Issues and PRs related to the SQLite subsystem.

Comments

@mcollina
Copy link
Member

I think we should plan to unflag node:sqlite, as it has been flagged for a while and we plan to use it in Undici to provide an HTTP cache store: nodejs/undici#3657.

@mcollina
Copy link
Member Author

@cjihrig what's missing?

@cjihrig
Copy link
Contributor

cjihrig commented Nov 14, 2024

I think at a minimum there should be some performance work done prior to unflagging because it will likely involve changing the compilation settings. See this comment.

It's probably worth asking @tniessen as well, as they have made several changes that would become semver majors if unflagged.

(Note, I will be slow to respond for the next day or so.)

@mcollina
Copy link
Member Author

Oh I mean to keep it experimental with a warning on usage, just unflagging it.

@RedYetiDev RedYetiDev added discuss Issues opened for discussions and feedbacks. experimental Issues and PRs related to experimental features. sqlite Issues and PRs related to the SQLite subsystem. labels Nov 14, 2024
@cjihrig
Copy link
Contributor

cjihrig commented Nov 15, 2024

Oh. I'd be happy to see the flag go. +1.

cjihrig added a commit to cjihrig/node that referenced this issue Nov 17, 2024
This commit allows the node:sqlite module to be used without
starting Node with a CLI flag. The module is still experimental.

Fixes: nodejs#55854
cjihrig added a commit to cjihrig/node that referenced this issue Nov 18, 2024
This commit allows the node:sqlite module to be used without
starting Node with a CLI flag. The module is still experimental.

Fixes: nodejs#55854
tpoisseau pushed a commit to tpoisseau/node that referenced this issue Nov 21, 2024
This commit allows the node:sqlite module to be used without
starting Node with a CLI flag. The module is still experimental.

Fixes: nodejs#55854
PR-URL: nodejs#55890
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Nov 26, 2024
This commit allows the node:sqlite module to be used without
starting Node with a CLI flag. The module is still experimental.

Fixes: nodejs#55854
PR-URL: nodejs#55890
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95 pushed a commit that referenced this issue Nov 26, 2024
This commit allows the node:sqlite module to be used without
starting Node with a CLI flag. The module is still experimental.

Fixes: #55854
PR-URL: #55890
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95 pushed a commit that referenced this issue Dec 10, 2024
This commit allows the node:sqlite module to be used without
starting Node with a CLI flag. The module is still experimental.

Fixes: #55854
PR-URL: #55890
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issues opened for discussions and feedbacks. experimental Issues and PRs related to experimental features. sqlite Issues and PRs related to the SQLite subsystem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants