Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented 'hello world' sample does not work for Addons #56173

Closed
geeksilva97 opened this issue Dec 7, 2024 · 0 comments · Fixed by #56172
Closed

Documented 'hello world' sample does not work for Addons #56173

geeksilva97 opened this issue Dec 7, 2024 · 0 comments · Fixed by #56172

Comments

@geeksilva97
Copy link
Contributor

Version

v22.11.0+

Platform

Darwin LM-JNVH7RPW6J 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:14:30 PDT 2024; root:xnu10063.141.2~1/RELEASE_ARM64_T6030 arm64

Subsystem

No response

What steps will reproduce the bug?

  1. Go to https://nodejs.org/api/addons.html#hello-world
  2. Copy the sample code into a hello.cc file
  3. Try to build it with node-gyp.

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior? Why is that the expected behavior?

N/A

What do you see instead?

Build fails with

../hello.cc:14:27: error: no matching member function for call to 'Set' 

args.GetReturnValue().Set(v8::String::NewFromUtf8(isolate, "world"));

Additional information

No response

@geeksilva97 geeksilva97 changed the title Documentes Hello world does not work for Addons Documented 'hello world' sample does not work for Addons Dec 8, 2024
nodejs-github-bot pushed a commit that referenced this issue Dec 9, 2024
PR-URL: #56172
Refs: #56173
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
aduh95 pushed a commit that referenced this issue Dec 10, 2024
PR-URL: #56172
Refs: #56173
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant