SSL sockets may leak when keepalive is enabled #5699
Labels
confirmed-bug
Issues with confirmed bugs.
http
Issues or PRs related to the http subsystem.
https
Issues or PRs related to the https subsystem.
memory
Issues and PRs related to the memory management or memory footprint.
net
Issues and PRs related to the net subsystem.
Comments
Fishrock123
added
http
|
It's worth mentioning that this happens because |
|
Nice spotting and nice fix. Worth mentioning that the only place that Would you be willing to make a pull request of your branch against node @saperal ? |
4 tasks
|
Done #5713 |
ChALkeR
added
the
memory
Fishrock123
pushed a commit
that referenced
this issue
Mar 22, 2016
SSL sockets leak whenever keep alive is enabled, ca option is set in the global agent, and requests are sent without the ca property. In the following case at Agent.prototype.createSocket a socket will be created with a hashtag name that includes data from the global agents’ ca property. On subsequent requests at Agent.prototype.addRequest we do not find the free socket, because the hashtag name generated there does not take into account the global agents’ ca property, thus creating a new socket and leaving the first socket to timeout. closes: #5699 PR-URL: #5713 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this issue
Mar 30, 2016
SSL sockets leak whenever keep alive is enabled, ca option is set in the global agent, and requests are sent without the ca property. In the following case at Agent.prototype.createSocket a socket will be created with a hashtag name that includes data from the global agents’ ca property. On subsequent requests at Agent.prototype.addRequest we do not find the free socket, because the hashtag name generated there does not take into account the global agents’ ca property, thus creating a new socket and leaving the first socket to timeout. closes: #5699 PR-URL: #5713 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this issue
Mar 30, 2016
SSL sockets leak whenever keep alive is enabled, ca option is set in the global agent, and requests are sent without the ca property. In the following case at Agent.prototype.createSocket a socket will be created with a hashtag name that includes data from the global agents’ ca property. On subsequent requests at Agent.prototype.addRequest we do not find the free socket, because the hashtag name generated there does not take into account the global agents’ ca property, thus creating a new socket and leaving the first socket to timeout. closes: #5699 PR-URL: #5713 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
issue is in: lib/_http_agent.js
The issue is reproducible whenever the
caproperty is set globally in the agent and an https request is made withhttps.request(ops)whereopsdoes not have the propertyca_http_agent.js @
Agent.prototype.createSocketthe
optionsare extended with the globaloptionsobject which containsca. IngetNamecais used in the name generation of the hash.however _http_agent.js @
Agent.prototype.addRequestThe
options(passed from the callhttps.request(ops)which don't have the propertyca) are used to get a hashtag which is now different. The socket leaks and is closed when the timeout hits. Meanwhile a new socket is created for the request.The text was updated successfully, but these errors were encountered: