make check ... Error: Cannot find module './eslint' ... node -v v6.0.0 #6408
Labels
build
Issues and PRs related to build files or the CI.
Comments
|
This is because ESLint isn't distributed in the tarball (at least that's what I saw @jbergstroem say). I'm not sure what the best workaround is for this version. Maybe installing ESLint or skipping jslint in the Makefile. |
|
Oh, see #6406 |
|
#6406 fixes this, I think? EDIT: … jinx. 😄 |
Fishrock123
pushed a commit
that referenced
this issue
May 4, 2016
Instead of invoking jslint/cpplint from the test target, call on the generic lint instead since it checks if eslint exists. Since our tarballs lacks eslint we now get a more graceful exit from `make test` instead of a traceback from jslint. PR-URL: #6406 Fixes: #6408 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this issue
May 4, 2016
Instead of invoking jslint/cpplint from the test target, call on the generic lint instead since it checks if eslint exists. Since our tarballs lacks eslint we now get a more graceful exit from `make test` instead of a traceback from jslint. PR-URL: nodejs#6406 Fixes: nodejs#6408 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
v6.0.0
Linux bodhisattva 4.4.0-21-generic logo ideas #37-Ubuntu SMP Mon Apr 18 18:33:37 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
After successfully compiling with normal
getting this error after issuing
make -C out BUILDTYPE=Release V=1
make[1]: Entering directory '/home/stens/other_src/node-v6.0.0/out'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/home/stens/other_src/node-v6.0.0/out'
ln -fs out/Release/node node
Running main() from gtest_main.cc
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from UtilTest
[ RUN ] UtilTest.ListHead
[ OK ] UtilTest.ListHead (0 ms)
[----------] 1 test from UtilTest (0 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (0 ms total)
[ PASSED ] 1 test.
/usr/bin/python tools/test.py --mode=release message parallel sequential -J
make jslint
make[1]: Entering directory '/home/stens/other_src/node-v6.0.0'
./node tools/jslint.js -J benchmark lib src test tools/doc
tools/eslint-rules tools/jslint.js
module.js:440
throw err;
^
Error: Cannot find module './eslint'
at Function.Module._resolveFilename (module.js:438:15)
at Function.Module._load (module.js:386:25)
at Module.require (module.js:466:17)
at require (internal/module.js:20:19)
at Object. (/home/stens/other_src/node-v6.0.0/tools/jslint.js:12:19)
at Module._compile (module.js:541:32)
at Object.Module._extensions..js (module.js:550:10)
at Module.load (module.js:456:32)
at tryModuleLoad (module.js:415:12)
at Function.Module._load (module.js:407:3)
Makefile:610: recipe for target 'jslint' failed
make[1]: *** [jslint] Error 1
make[1]: Leaving directory '/home/stens/other_src/node-v6.0.0'
Makefile:118: recipe for target 'test' failed
make: *** [test] Error 2
doing this has no impact
The text was updated successfully, but these errors were encountered: