Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky parallel/test-debug-port-cluster #6754

Closed
Trott opened this issue May 14, 2016 · 5 comments
Closed

Investigate flaky parallel/test-debug-port-cluster #6754

Trott opened this issue May 14, 2016 · 5 comments
Labels
test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented May 14, 2016

  • Version: master
  • Platform: ppce-ubuntu1404
  • Subsystem: debugger

Example failure on CI: https://ci.nodejs.org/job/node-test-commit-plinux/2460/nodes=ppcbe-ubuntu1404/tapTestReport/test.tap-181/

/cc @bnoordhuis
@Trott Trott added debugger test Issues and PRs related to the tests. labels May 14, 2016
@Trott
Copy link
Member Author

Trott commented May 14, 2016

/cc @nodejs/testing

@mscdex
Copy link
Contributor

mscdex commented May 14, 2016

I just saw this on FreeBSD too FWIW: https://ci.nodejs.org/job/node-test-commit-freebsd/2478/nodes=freebsd10-64/tapTestReport/test.tap-373/

@Trott Trott changed the title Investigate flaky parallel/test-debug-port-cluster on ppce-ubuntu1404 Investigate flaky parallel/test-debug-port-cluster May 14, 2016
@Trott Trott added freebsd Issues and PRs related to the FreeBSD platform. and removed freebsd Issues and PRs related to the FreeBSD platform. labels May 14, 2016
@Trott
Copy link
Member Author

Trott commented May 14, 2016

And SmartOS: https://ci.nodejs.org/job/node-test-commit-smartos/2496/nodes=smartos14-64/console

Something is definitely wrong with that test....

@Trott
Copy link
Member Author

Trott commented May 14, 2016

Er...uh...or perhaps equally likely, something is wrong with the code base but the test only catches it intermittently...

Trott added a commit to Trott/io.js that referenced this issue May 15, 2016
@Trott
test: add logging for test-debug-port-cluster
f547ca6 
The test is currently flaky and CI provides no real information because
the test times out rather than failing on an assertion. Add logging to
gather more information about the failure.

Refs: nodejs#6754
@Trott Trott mentioned this issue May 15, 2016
Closed
2 tasks
@Trott
Copy link
Member Author

Trott commented May 15, 2016

This appears to fix the flakiness in this test: #6769

Trott added a commit to Trott/io.js that referenced this issue May 16, 2016
@Trott
test: add logging for test-debug-port-cluster
f73296a 
The test is currently flaky and CI provides no real information because
the test times out rather than failing on an assertion. Add logging to
gather more information about the failure.

Refs: nodejs#6754
Trott added a commit to Trott/io.js that referenced this issue May 18, 2016
@Trott
test: add logging for test-debug-port-cluster
2c926dc 
The test is currently flaky and CI provides no real information because
the test times out rather than failing on an assertion. Add logging to
gather more information about the failure.

Refs: nodejs#6754
PR-URL: nodejs#6769
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott Trott closed this as completed in 0350505 May 18, 2016
MylesBorins pushed a commit that referenced this issue May 23, 2016
@Trott
test: add logging for test-debug-port-cluster
f8144e4 
The test is currently flaky and CI provides no real information because
the test times out rather than failing on an assertion. Add logging to
gather more information about the failure.

Refs: #6754
PR-URL: #6769
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue May 23, 2016
@Trott
test: fix test-debug-port-cluster flakiness
49a5941 
Remove port increment by `1337` which appears to sometimes result in a
port that is already in use. There is no reason not to use
`common.PORT`.

PR-URL: #6769
Fixes: #6754
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fishrock123 pushed a commit that referenced this issue May 23, 2016
@Trott @Fishrock123
test: add logging for test-debug-port-cluster
2ee4ed4 
The test is currently flaky and CI provides no real information because
the test times out rather than failing on an assertion. Add logging to
gather more information about the failure.

Refs: #6754
PR-URL: #6769
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fishrock123 pushed a commit that referenced this issue May 23, 2016
@Trott @Fishrock123
test: fix test-debug-port-cluster flakiness
8abd7a6 
Remove port increment by `1337` which appears to sometimes result in a
port that is already in use. There is no reason not to use
`common.PORT`.

PR-URL: #6769
Fixes: #6754
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this issue Jun 2, 2016
@Trott @rvagg
test: add logging for test-debug-port-cluster
5374afd 
The test is currently flaky and CI provides no real information because
the test times out rather than failing on an assertion. Add logging to
gather more information about the failure.

Refs: #6754
PR-URL: #6769
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this issue Jun 2, 2016
@Trott @rvagg
test: fix test-debug-port-cluster flakiness
2cf3a53 
Remove port increment by `1337` which appears to sometimes result in a
port that is already in use. There is no reason not to use
`common.PORT`.

PR-URL: #6769
Fixes: #6754
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mscdex @Trott