-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--inspect connection dies before profiler captures trace #7088
Comments
/cc @eugeneo |
I am unable to reproduce the issue. I get a prompt "Waiting for the debugger to disconnect..." whenever I run script to a completion with an inspector connected. Note that you may be hitting a different issue that we will upload a fix shortly - sometimes V8 inspector does not attach to V8 running long JS script. Have you tried running your application with "--debug-brk" command line switch? It enables inspector connection before running the script. |
@eugeneo i can easily repro it. I start with --debug-brk and start profiling while on a breakpoint. App finishes, connections terminates. This is a regression. |
I'll try it out to confirm its fixed. On Monday, June 13, 2016, Ali Ijaz Sheikh notifications@github.com wrote:
|
Its a common scenario to profile the execution of a node script. e.g the tsc compiler. The use case is to get a flamechart of the execution of a script. When the script finishes the debugging connection is closed so the flamechart cannot be analyzed.
Expected:
when capturing cpu profiles in inspect mode, the debugging connection should remain open until the profile is fully captured and ready for post analysis. Alternatively there should be a way to tell inspect not to kill the connection once the script finishes.
/cc @ofrobots @pavelfeldman
The text was updated successfully, but these errors were encountered: