-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
failure trying to compile for arm64+android #7731
Comments
What does |
|
That's indeed the wrong architecture. icupkg runs as part of the build so it should have been built for x86_64. You probably need to compile with |
That got me a lot farther. However, it's now failing in another spot. It looks again like it is trying to use the wrong architecture, but this time during linking:
|
It's possible you also need to pass |
Making more progress. :-) After adding that override, it now aborts at:
|
What happens when you apply this patch? diff --git a/common.gypi b/common.gypi
index 646db0d..7c535ce 100644
--- a/common.gypi
+++ b/common.gypi
@@ -301,9 +301,13 @@
}],
],
}],
- [ 'OS=="android"', {
- 'defines': ['_GLIBCXX_USE_C99_MATH'],
- 'libraries': [ '-llog' ],
+ ['OS=="android"', {
+ 'target_conditions': [
+ ['_toolset="target"', {
+ 'defines': [ '_GLIBCXX_USE_C99_MATH' ],
+ 'libraries': [ '-llog' ],
+ }],
+ ],
}],
['OS=="mac"', {
'defines': ['_DARWIN_USE_64_BIT_INODE=1'], |
creating ./config.gypi
|
I am not familiar with GYP, but I thought that _toolset="target" might ought to be _toolset=="target". I made that change and am currently building. This is the end of my work day, but I will report back tomorrow with my findings. Thanks so much for your help! |
Ai, I don't know how that typo ended up in there but it should indeed read |
With this patch I got a successful compile this morning. Thank you! |
Don't link binaries that run on the host system against liblog, it breaks cross-compiling for android. Fixes: nodejs#7731 PR-URL: nodejs#7762 Reviewed-By: Anna Henningsen <anna@addaleax.net>
I am trying to compile the source for arm64 using ndk-12b. I modified the android-configure script to allow arm64 as a target, and pointed to the arm64 toolchain. After grinding for a while, the build aborted here:
The build itself is being done on:
Linux usmeps008 3.13.0-85-generic #129-Ubuntu SMP Thu Mar 17 20:50:15 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
Using Android NDK 12b
Thanks for your help!
[edit bnoordhuis - fixed formatting]
The text was updated successfully, but these errors were encountered: