Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.3.1 src tarball: missing files and directories #7872

Closed
jelmd opened this issue Jul 25, 2016 · 12 comments
Closed

6.3.1 src tarball: missing files and directories #7872

jelmd opened this issue Jul 25, 2016 · 12 comments
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. question Issues that look for answers.

Comments

@jelmd
Copy link

jelmd commented Jul 25, 2016

https://nodejs.org/dist/v6.3.1/node-v6.3.1.tar.[gx]z source tar balls seems to be screwed up: e.g.
tools/{osx-pkg.pmdoc,pkgsrc,eslint,eslint-rules}/ are missing, whereby at least the latter 2 in turn break doc building:

Input file = doc/api/os.md
module.js:442
    throw err;
    ^

Error: Cannot find module '/export/scratch/build/node-v6.3.1/tools/eslint/node_modules/js-yaml'
    at Function.Module._resolveFilename (module.js:440:15)
    at Function.Module._load (module.js:388:25)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/export/scratch/build/node-v6.3.1/tools/doc/node_modules/js-yaml/index.js:15:18)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
...
@mscdex
Copy link
Contributor

mscdex commented Jul 25, 2016

I think this was done intentionally awhile back in an effort to reduce the distributed tarball size. You will need to checkout the git repo to build docs and the like.

@mscdex mscdex added question Issues that look for answers. doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. labels Jul 25, 2016
@jelmd
Copy link
Author

jelmd commented Jul 25, 2016

:( - wondering who cares about 1-2 MB these days ...

Anyway, shouldn't it be documented somewhere?

@mscdex
Copy link
Contributor

mscdex commented Jul 25, 2016

I guess something like #7218 is missing for make doc. /cc @addaleax

@lungbubble
Copy link

So...how does one do this "git repo" thing to "build docs and the like" to resolve this issue?

@addaleax
Copy link
Member

addaleax commented Aug 7, 2016

Running git clone https://github.com/nodejs/node.git should give you a node directory containing everything in this repository.

It’s probably easier and works just as well to just run npm install in the tools/doc/ directory of the tarball, though.

@lungbubble
Copy link

had to go to folder with git.py in it and typed "c:\python27\python.exe git.py clone https://github.com/nodejs/node.git" and something happened without any output in the console. npm install didn't begin to work at that point. how do I "run npm install in the tools/doc/ directory of the tartball"? I can't any such folder. Is there a way to just download this thing without those missing files by chance?

@MylesBorins
Copy link
Contributor

@lungbubble you should not have to use python to clone the repo

do you have git installed?

you can get git here.

Once you have git installed you can use the command that was mentioned above git clone https://github.com/nodejs/node.git to clone the repo

If you want to learn more about git you can read this intro

@lungbubble
Copy link

Ty, I installed the git clone, typed that in program files\nodejs and it did a bunch of stuff. Then I typed npm install npm -g (also just npm install). This was the result I got:

npm ERR! not a package c:\program files\nodejs\npm
npm ERR! addlocal Could not install c:\program files nodejs\npm
npm ERR! Windows_NT 6.1.7601
npm ERR! argy "C:\program files\nodejs\node.exe" "C:\program files\nodejs\node_modules\npm\bin\npm-cli.js" "install" "npm" "-g"
npm ERR! v6.3.1
npm ERR! v3.10.3
npm ERR! path c:\users\MyUser\AppData\Local\Temp\npm-8488-242c2023\unpack-8456689f2\package.json
npm ERR! code ENOENT
npm ERR! errno -4058
npm ERR! syscall open

npm ERR! enoent ENOENT: no such file or directory, open 'C:\users\MyUser\AppData\Local\Temp\npm-8488-242c2023\unpack-845689f2\package.json'
npmE ERR! enoent ENOENT: no such file or directory, open 'C:\Users\Myuser\AppData\Local\Temp\npm-8488-242c2023\unpack-845689f2\package.json'
npm ERR! enoent This is likely not a problem with npm itself
npm ERR! enoent and this is related to npm not being able to find a file

I have no idea why its checking for files in my app data/local stuff as npm is in my program files\nodejs.

@MylesBorins
Copy link
Contributor

@lungbubble let's step back for a moment.

what is your ultimate goal? what are you trying to do? get a local copy of
the docs?

On Sun, Aug 7, 2016, 2:16 PM lungbubble notifications@github.com wrote:

Ty, I installed the git clone, typed that in program files\nodejs and it
did a bunch of stuff. Then I typed npm install npm -g (also just npm
install). This was the result I got:

npm ERR! not a package c:\program files\nodejs\npm
npm ERR! addlocal Could not install c:\program files nodejs\npm
npm ERR! Windows_NT 6.1.7601
npm ERR! argy "C:\program files\nodejs\node.exe" "C:\program
files\nodejs\node_modules\npm\bin\npm-cli.js" "install" "npm" "-g"
npm ERR! v6.3.1
npm ERR! v3.10.3
npm ERR! path
c:\users\MyUser\AppData\Local\Temp\npm-8488-242c2023\unpack-8456689f2\package.json
npm ERR! code ENOENT
npm ERR! errno -4058
npm ERR! syscall open

npm ERR! enoent ENOENT: no such file or directory, open
'C:\users\MyUser\AppData\Local\Temp\npm-8488-242c2023\unpack-845689f2\package.json'
npmE ERR! enoent ENOENT: no such file or directory, open
'C:\Users\Myuser\AppData\Local\Temp\npm-8488-242c2023\unpack-845689f2\package.json'
npm ERR! enoent This is likely not a problem with npm itself
npm ERR! enoent and this is related to npm not being able to find a file

I have no idea why its checking for files in my app data/local stuff as
npm is in my program files\nodejs.


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#7872 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAecVyqfw3jQcujvzanduDiJj9Iwo6BNks5qdkszgaJpZM4JUZgJ
.

@jbergstroem
Copy link
Member

We did a distinction between a developer and user. If you want to e.g. generate documentation instead of using the one that is generate for you, or for instance invoke lint you will need a git checkout. Compiling and verifying the generated binary (make test) works just fine as a user.

@lungbubble
Copy link

lungbubble commented Aug 8, 2016

I'm trying to run a python script which states I need to run "grunt build" before running the script. From what I've read (i've gone through so much stuff now, I might be missing a piece or two) I need to install nodejs to do the grunt build. So I'm just trying to install nodejs so that I can use "grunt build" so I can run the script I have.

@MylesBorins
Copy link
Contributor

@lungbubble it would appear you are heading down the wrong path. If you would like to install node please follow the instructions found at --> http://nodejs.org/download/

addaleax added a commit to addaleax/node that referenced this issue Sep 8, 2016
Run `npm install` before building the documentation from release
tarballs. The doctool currently depends on `js-yaml`, which
is imported from the `tools/eslint` subtree; however, release
tarballs don’t contain that directory.

Running `npm install` is clearly not a beautiful solution,
but it works.

Fixes: nodejs#7872
Fishrock123 pushed a commit that referenced this issue Oct 11, 2016
Run `npm install` before building the documentation from release
tarballs. The doctool currently depends on `js-yaml`, which
is imported from the `tools/eslint` subtree; however, release
tarballs don’t contain that directory.

Running `npm install` is clearly not a beautiful solution,
but it works.

Fixes: #7872
PR-URL: #8413
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Oct 14, 2016
Run `npm install` before building the documentation from release
tarballs. The doctool currently depends on `js-yaml`, which
is imported from the `tools/eslint` subtree; however, release
tarballs don’t contain that directory.

Running `npm install` is clearly not a beautiful solution,
but it works.

Fixes: #7872
PR-URL: #8413
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Oct 17, 2016
Run `npm install` before building the documentation from release
tarballs. The doctool currently depends on `js-yaml`, which
is imported from the `tools/eslint` subtree; however, release
tarballs don’t contain that directory.

Running `npm install` is clearly not a beautiful solution,
but it works.

Fixes: #7872
PR-URL: #8413
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this issue Oct 18, 2016
Run `npm install` before building the documentation from release
tarballs. The doctool currently depends on `js-yaml`, which
is imported from the `tools/eslint` subtree; however, release
tarballs don’t contain that directory.

Running `npm install` is clearly not a beautiful solution,
but it works.

Fixes: #7872
PR-URL: #8413
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Oct 26, 2016
Run `npm install` before building the documentation from release
tarballs. The doctool currently depends on `js-yaml`, which
is imported from the `tools/eslint` subtree; however, release
tarballs don’t contain that directory.

Running `npm install` is clearly not a beautiful solution,
but it works.

Fixes: #7872
PR-URL: #8413
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. question Issues that look for answers.
Projects
None yet
Development

No branches or pull requests

7 participants