Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration option to permanently turn on --preserve-symlinks #8509

Closed
AlastairTaft opened this issue Sep 13, 2016 · 5 comments
Closed

Configuration option to permanently turn on --preserve-symlinks #8509

AlastairTaft opened this issue Sep 13, 2016 · 5 comments
Labels
feature request Issues that request new features to be added to Node.js. module Issues and PRs related to the module subsystem.

Comments

@AlastairTaft
Copy link

Developing packages with peer dependencies is really really hard, I lose so many hours a day trying to setup my dev environment in just the right way so it works.

I've only once managed to get the NODE_PATH=./node_modules workaround working, I'm not sure why it doesn't work for me, perhaps it's to do with how I configure webpack.

That flag would save me when developing locally except it doesn't seem to work with webpack and browserify, is there anyway we can permanently configure it to on so we don't have to pass it as an argument for every node process? That way webpack and browserify would work with it.

@mscdex mscdex added module Issues and PRs related to the module subsystem. feature request Issues that request new features to be added to Node.js. labels Sep 13, 2016
@evanlucas
Copy link
Contributor

you could rename your node binary to something else and then create a shell script (named node) that passes all arguments to the real node binary and appends the --preserve-symlinks flag

@AlastairTaft
Copy link
Author

That's a nice idea, thanks, I'll try that.

@imyller
Copy link
Member

imyller commented Sep 13, 2016

It should be possible to add support for environment variable NODE_PRESERVE_SYMLINKS.

Just like existing variables NODE_DISABLE_COLORS with value 1 or NODE_ICU_DATA as an alternative to --icu-data-dir option.

@AlastairTaft
Copy link
Author

That would be a nicer solution

@mlucool
Copy link

mlucool commented Sep 15, 2016

This would be a huge help for us too

mlucool pushed a commit to mlucool/node that referenced this issue Oct 14, 2016
Add a way through environment variables to set the --preserve-symlinks
flag. Any non-null value of NODE_PRESERVE_SYMLINKS will enable symlinks.

Fixes: nodejs#8509
evanlucas pushed a commit that referenced this issue Nov 2, 2016
Add a way through environment variables to set the --preserve-symlinks
flag. Any non-null value of NODE_PRESERVE_SYMLINKS will enable symlinks.

PR-URL: #8749
Fixes: #8509
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issues that request new features to be added to Node.js. module Issues and PRs related to the module subsystem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants