Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: cleanup/update test-dgram-error-message-address.js #8925

Closed
Goyapa opened this issue Oct 4, 2016 · 1 comment
Closed

test: cleanup/update test-dgram-error-message-address.js #8925

Goyapa opened this issue Oct 4, 2016 · 1 comment
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.

Comments

@Goyapa
Copy link
Contributor

Goyapa commented Oct 4, 2016

  • Version: 7
  • Subsystem: dgram

I am working on this.
@Fishrock123 Fishrock123 added the test Issues and PRs related to the tests. label Oct 4, 2016
@mscdex mscdex added the dgram Issues and PRs related to the dgram subsystem / UDP. label Oct 4, 2016
@imyller
Copy link
Member

imyller commented Oct 7, 2016

Ref: #8938

@imyller imyller mentioned this issue Oct 7, 2016
Closed
2 tasks
@targos targos closed this as completed in 6a73d61 Nov 28, 2016
MylesBorins pushed a commit that referenced this issue Nov 30, 2016
@Goyapa @MylesBorins
test: cleanup test-dgram-error-message-address
24fc1e2 
* var -> const
* assert.equal() -> assert.strictEqual()
* assert.notEqual() -> assert.notStrictEqual()

Fixes: #8925
PR-URL: #8938
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this issue Nov 30, 2016
@Goyapa @MylesBorins
test: cleanup test-dgram-error-message-address
9144d37 
* var -> const
* assert.equal() -> assert.strictEqual()
* assert.notEqual() -> assert.notStrictEqual()

Fixes: #8925
PR-URL: #8938
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax pushed a commit that referenced this issue Dec 5, 2016
@Goyapa @addaleax
test: cleanup test-dgram-error-message-address
d06f010 
* var -> const
* assert.equal() -> assert.strictEqual()
* assert.notEqual() -> assert.notStrictEqual()

Fixes: #8925
PR-URL: #8938
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mscdex @Goyapa @Fishrock123 @imyller