Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add regex check to error expectation #10038

Closed
wants to merge 2 commits into from
Closed

test: Add regex check to error expectation #10038

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d19295b
test: Add regex check to error expectation
Dec 1, 2016
70f5564
Match full error message
Dec 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/parallel/test-buffer-bad-overload.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ assert.doesNotThrow(function() {

assert.throws(function() {
Buffer.from(10, 'hex');
});
}, /argument must not be a number/);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to test the whole error message:

/^TypeError: "value" argument must not be a number$/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the benefit of full text message checking?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samshull it helps tracking changes in the error message/type as those changes are breaking changes (semver-major).


assert.doesNotThrow(function() {
Buffer.from('deadbeaf', 'hex');
Expand Down