Simplified the test by using common.mustCall(). Use of common.mustCal… #10040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l(), made assert require and use of successes variable redundant
imyller
added
code-and-learn
gibfahn
suggested changes
Dec 2, 2016
There was a problem hiding this comment.
Could you modify the commit message so that it meets the contributing guidelines?
Something like:
test: refactor test-fs-fsync
Simplified the test by using common.mustCall(). Use of
common.mustCall(), made assert require and use of successes variable
redundant.
If you amend your commit and push to your test-fs-sync branch, it will automatically update the Pull Request.
cjihrig
requested changes
Dec 3, 2016
|
|
||
| var file = path.join(common.fixturesDir, 'a.js'); | ||
|
|
||
| fs.open(file, 'a', 0o777, function(err, fd) { | ||
| fs.open(file, 'a', 0o777, common.mustCall(function(err, fd) { | ||
| if (err) throw err; |
There was a problem hiding this comment.
Could you please make this assert.ifError(err).
There was a problem hiding this comment.
Actually, you could change the other occurrences of if (err) throw err; as well.
| var fs = require('fs'); | ||
| var successes = 0; | ||
| const path = require('path'); | ||
| const fs = require('fs'); | ||
|
|
||
| var file = path.join(common.fixturesDir, 'a.js'); |
|
Ping @uttampawar. |
|
After rebasing against master and resolving conflicts, there are no changes to be made to the file. In other words, someone might have already contributed the same or similar changes independently. I'm going to close this. I'm glad to see your other pull request landed, though! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Simplified test by using common.mustCall(). This also made assert module and sucesses variable redundant.
…l(), made assert require and use of successes variable redundant