Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test fix - fix to /test/parallel/test-cluster #10047

Closed
wants to merge 2 commits into from
Closed

Test fix - fix to /test/parallel/test-cluster #10047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e715234
test: fix test-child-process-stdin.js
navulirs Dec 1, 2016
21ab812
test: fixed assert.strictEqual test/parallel/test-cluster-net-listen.js
navulirs Dec 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/parallel/test-child-process-stdin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ cat.on('exit', common.mustCall(function(status) {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two assert.ok() calls in this file that would be better off as strictEqual() calls.

cat.on('close', common.mustCall(function() {
if (common.isWindows) {
assert.equal('hello world\r\n', response);
assert.strictEqual('hello world\r\n', response);
} else {
assert.equal('hello world', response);
assert.strictEqual('hello world', response);
}
}));
2 changes: 1 addition & 1 deletion test/parallel/test-cluster-net-listen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ var net = require('net');
if (cluster.isMaster) {
// ensure that the worker exits peacefully
cluster.fork().on('exit', common.mustCall(function(statusCode) {
assert.equal(statusCode, 0);
assert.strictEqual(statusCode, 0);
}));
} else {
// listen() without port should not trigger a libuv assert
Expand Down