Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typo for decipher.final. #10086

Closed
wants to merge 1 commit into from
Closed

Conversation

iamchenxin
Copy link
Contributor

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

The output_encoding parameter of decipher.final should be as the same as decipher.update.
So output_encoding: 'latin1'|'base64'|'hex' to output_encoding: 'latin1'|'ascii'|'utf8'.

The `output_encoding` parameter should be as the same as `decipher.update`.
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Dec 2, 2016
@addaleax
Copy link
Member

addaleax commented Dec 4, 2016

Landed in ca9784e, thanks for the contribution!

@addaleax addaleax closed this Dec 4, 2016
addaleax pushed a commit that referenced this pull request Dec 4, 2016
The `output_encoding` parameter should be as the same as
`decipher.update`.

PR-URL: #10086
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Dec 5, 2016
The `output_encoding` parameter should be as the same as
`decipher.update`.

PR-URL: #10086
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
2 tasks
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
The `output_encoding` parameter should be as the same as
`decipher.update`.

PR-URL: nodejs#10086
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
The `output_encoding` parameter should be as the same as
`decipher.update`.

PR-URL: #10086
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
The `output_encoding` parameter should be as the same as
`decipher.update`.

PR-URL: #10086
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants