-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: correct it's vs. its usage #10098
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a few instances where `it's` was being used where the possessive `its` was called for. Some additional minor copy-editing of nearby text (adding a comma and fixing a comma splice) was also performed.
addaleax
approved these changes
Dec 2, 2016
cjihrig
approved these changes
Dec 3, 2016
lpinca
approved these changes
Dec 3, 2016
targos
approved these changes
Dec 3, 2016
jasnell
approved these changes
Dec 5, 2016
jasnell
pushed a commit
that referenced
this pull request
Dec 5, 2016
Fix a few instances where `it's` was being used where the possessive `its` was called for. Some additional minor copy-editing of nearby text (adding a comma and fixing a comma splice) was also performed. PR-URL: #10098 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in 6b43c3f |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 6, 2016
Fix a few instances where `it's` was being used where the possessive `its` was called for. Some additional minor copy-editing of nearby text (adding a comma and fixing a comma splice) was also performed. PR-URL: #10098 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
Fix a few instances where `it's` was being used where the possessive `its` was called for. Some additional minor copy-editing of nearby text (adding a comma and fixing a comma splice) was also performed. PR-URL: nodejs#10098 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
Fix a few instances where `it's` was being used where the possessive `its` was called for. Some additional minor copy-editing of nearby text (adding a comma and fixing a comma splice) was also performed. PR-URL: #10098 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Fix a few instances where `it's` was being used where the possessive `its` was called for. Some additional minor copy-editing of nearby text (adding a comma and fixing a comma splice) was also performed. PR-URL: #10098 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Fix a few instances where
it's
was being used where the possessiveits
was called for. Some additional minor copy-editing of nearby text(adding a comma and fixing a comma splice) was also performed.