inspector: stop relying on magic strings #10159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
bnoordhuis
approved these changes
Dec 7, 2016
| void ResumeStartup() { | ||
| uv_sem_post(&start_sem_); | ||
| } | ||
|
|
||
| private: | ||
| template<typename Action> |
There was a problem hiding this comment.
Space before '<' here and elsewhere.
|
Landed as d8c7534 |
|
@eugeneo Doesn't land cleanly on v7.x fwiw |
|
@Fishrock123 I did a manual rebase - https://github.com/eugeneo/node/commit/a2d33e94c3df6888d6533dcd3ee6e6d15d87c81f |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
Inspector uses magical strings to communicate some events between main thread and transport thread. This change replaces those strings with enums that are more mainatainable (and remove unnecessary encodings/decodings) PR-URL: nodejs#10159 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos
pushed a commit
that referenced
this pull request
Jan 28, 2017
Inspector uses magical strings to communicate some events between main thread and transport thread. This change replaces those strings with enums that are more mainatainable (and remove unnecessary encodings/decodings) PR-URL: #10159 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
Inspector uses magical strings to communicate some events between main thread and transport thread. This change replaces those strings with enums that are more mainatainable (and remove unnecessary encodings/decodings) PR-URL: nodejs#10159 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
Inspector uses magical strings to communicate some events between main thread and transport thread. This change replaces those strings with enums that are more mainatainable (and remove unnecessary encodings/decodings) PR-URL: nodejs#10159 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
A backport PR would be required in order for this to land in v6 |
|
I don't think this needs to be backported... |
|
Awesome. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
inspector: internal datastructures were slightly altered
Description of change
Inspector uses magical strings to communicate some events between
main thread and transport thread. This change replaces those strings
with enums that are more mainatainable (and remove unnecessary
encodings/decodings)