test: use strictEqual in test fixtures symlinked #10182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v7.x
test
cjihrig
approved these changes
Dec 9, 2016
italoacasas
approved these changes
Dec 9, 2016
thefourtheye
reviewed
Dec 9, 2016
| assert.equal(foo.dep1.bar.version, 'CORRECT_VERSION'); | ||
| assert.equal(foo.dep2.bar.version, 'CORRECT_VERSION'); | ||
| assert.equal(__filename, linkScriptTarget); | ||
| const foo = require('./foo'); |
There was a problem hiding this comment.
Can you move this to the top, along with other requires?
| @@ -6,8 +6,8 @@ const path = require('path'); | |||
| const linkScriptTarget = path.join(common.fixturesDir, | |||
| '/module-require-symlink/symlinked.js'); | |||
There was a problem hiding this comment.
Now that you are changing this file, I would prefer to write this as
path.join(common.fixturesDir, 'module-require-symlink', 'symlinked.js')Can you please do this as well?
edsadr
force-pushed
the
test-fixtures-symlinked
branch
from
fcae6aa to
a683ad6
Compare
|
@thefourtheye just did those changes you requested |
| @@ -1,13 +1,13 @@ | |||
| 'use strict'; | |||
| const assert = require('assert'); | |||
| const common = require('../../common'); | |||
There was a problem hiding this comment.
This should be the first require in the tests.
use strictEqual assertions in test fixtures for modules symlinked
edsadr
force-pushed
the
test-fixtures-symlinked
branch
from
a683ad6 to
ace207f
Compare
|
@thefourtheye did the last change too |
|
@Fishrock123 it's normal that the bot is trying to add the label on every commit ? |
|
Landed e467d37 Thanks for the contribution |
italoacasas
pushed a commit
that referenced
this pull request
Dec 13, 2016
- using strictEqual instead equal - common dependency should be the first one - using path.join instead relative path PR-URL: #10182 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
AnnaMag
pushed a commit
to AnnaMag/node
that referenced
this pull request
Dec 13, 2016
- using strictEqual instead equal - common dependency should be the first one - using path.join instead relative path PR-URL: nodejs#10182 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
evanlucas
pushed a commit
that referenced
this pull request
Dec 14, 2016
- using strictEqual instead equal - common dependency should be the first one - using path.join instead relative path PR-URL: #10182 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 22, 2017
- using strictEqual instead equal - common dependency should be the first one - using path.join instead relative path PR-URL: #10182 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
- using strictEqual instead equal - common dependency should be the first one - using path.join instead relative path PR-URL: #10182 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
- using strictEqual instead equal - common dependency should be the first one - using path.join instead relative path PR-URL: #10182 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
use strictEqual assertions in test fixtures for modules symlinked