doc: some fixes in repl.md #10244

vsemozhetbyt · 2016-12-13T00:00:17Z

Checklist

documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

doc, repl

Description of change

var => let / const.
White space unification (add an infix space in an argument list; change > into > (with a trailing space) in code bits and output examples; explicitly clarify that default REPL prompt contains a trailing space).
Fix an output example (make _ reassignment example match with the current output; extend the example for more clarity).
Fix a function name (eval => myEval to not shadow the global eval).
Replace anonymous functions with an object shorthand and an arrow function.
Add the valid link for curl(1) (The current autoinserted link leads to 404 page).

I am sorry I've messed up the previous PR by an inexperienced rebasing during resolving a conflict. Excuse me for wasting your time.

Add an infix space in an argument list. Change `>` into `> ` in code bits and output examples. Explicitly clarify that default REPL prompt contains a trailing space.

Make `_` reassignment example match more with the current output. Extend the example for more clarity.

`eval` => `myEval` to not shadow the global `eval`

Replaced with an object shorthand and an arrow function.

vsemozhetbyt · 2016-12-14T22:27:42Z

/cc @nodejs/documentation

vsemozhetbyt · 2016-12-16T16:26:10Z

@addaleax, @eljefedelrodeodeljefe, @lance, you had reviewed the previous ill-fated PR. If anybody has the time, could you please look at this? Sorry for the disturbing.

addaleax

LGTM with a grammar nit

addaleax · 2016-12-17T01:15:29Z

doc/api/repl.md

-declared either implicitly or using the `var` keyword are declared at the
-`global` scope.
+Unless otherwise scoped within blocks or functions, variables declared
+either implicitly, or using the `const`, `let`, or `var` keywords


The , here doesn’t seem quite right to me?

@addaleax Do you mean "let, or var"? It is a @lance's sentence. It seems he uses Oxford comma here. Should I change it to "let or var"?

Or do you mean another comma?

Oh, sorry. I mean the one after implicitly… the Oxford comma after let seems okay here :)

Amended with the last commit. Thank you :)

The current autoinserted link leads to 404 page.

thefourtheye · 2016-12-20T23:14:03Z

cc @princejwesley

vsemozhetbyt · 2016-12-25T15:08:22Z

@addaleax, @jasnell, @thefourtheye Could this be landed?

PR-URL: #10244 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Add an infix space in an argument list. Change `>` into `> ` in code bits and output examples. Explicitly clarify that default REPL prompt contains a trailing space. PR-URL: #10244 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Make `_` reassignment example match more with the current output. Extend the example for more clarity. PR-URL: #10244 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

`eval` => `myEval` to not shadow the global `eval` PR-URL: #10244 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Replaced with an object shorthand and an arrow function. PR-URL: #10244 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

The current autoinserted link leads to 404 page. PR-URL: #10244 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax · 2016-12-25T18:52:25Z

@vsemozhetbyt Thanks for the ping!

Landed in 45c9ca7...f501178.