Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: server close event does not have an argument #1025

Closed
wants to merge 3 commits into from
Closed

doc: server close event does not have an argument #1025

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5059401
doc: server close event does not have an argument
sam-github Mar 2, 2015
ad1df21
fixup
sam-github Jul 18, 2015
cad0cb3
doc: a listener, not "an" listener
sam-github Jul 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions doc/api/net.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ Listening on a file descriptor is not supported on Windows.

This function is asynchronous. When the server has been bound,
['listening'][] event will be emitted.
the last parameter `callback` will be added as an listener for the
The last parameter `callback` will be added as an listener for the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a listener

['listening'][] event.

### server.listen(options[, callback])
Expand Down Expand Up @@ -228,10 +228,10 @@ shown below.

Stops the server from accepting new connections and keeps existing
connections. This function is asynchronous, the server is finally
closed when all connections are ended and the server emits a `'close'`
event. Optionally, you can pass a callback to listen for the `'close'`
event. If present, the callback is invoked with any potential error
as the first and only argument.
closed when all connections are ended and the server emits a ['close'][] event.
The optional `callback` will be called once the `'close'` event occurs. Unlike
that event, it will be called with an Error as its only argument if the server
was not open when it was closed.

### server.address()

Expand Down Expand Up @@ -313,7 +313,7 @@ event is not emitted until all connections are ended.

* {Error Object}

Emitted when an error occurs. The `'close'` event will be called directly
Emitted when an error occurs. The ['close'][] event will be called directly
following this event. See example in discussion of `server.listen`.

## Class: net.Socket
Expand Down Expand Up @@ -581,7 +581,7 @@ following this event.

### Event: 'close'

* `had_error` {Boolean} true if the socket had a transmission error
* `had_error` {Boolean} `true` if the socket had a transmission error.

Emitted once the socket is fully closed. The argument `had_error` is a boolean
which says if the socket was closed due to a transmission error.
Expand All @@ -601,6 +601,7 @@ Returns true if input is a version 4 IP address, otherwise returns false.

Returns true if input is a version 6 IP address, otherwise returns false.

['close']: #net_event_close
['connect']: #net_event_connect
['connection']: #net_event_connection
['end']: #net_event_end
Expand Down