Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-debug-port #10316

Merged
merged 1 commit into from
Dec 19, 2016
Merged

test: fix flaky test-debug-port #10316

merged 1 commit into from
Dec 19, 2016

Conversation

santigimeno
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

It can happen that first data chunk received in stdout is not exactly
'debug> '. Make sure the exit condition is met.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 17, 2016
@santigimeno
Copy link
Member Author

I was sometimes getting this error locally:

=== release test-debug-prompt ===                    
Path: parallel/test-debug-prompt
assert.js:85
  throw new assert.AssertionError({
  ^
AssertionError: 'debug> \b< Debugger listening on 127.0.0.1:5858\ndebug> \bconnecting to 127.0.0.1:5858 ... ok\ndebug> ' === 'debug> '
    at Socket.proc.stdout.once.common.mustCall (/Users/sgimeno/node/node/test/parallel/test-debug-prompt.js:11:10)
    at Socket.<anonymous> (/Users/sgimeno/node/node/test/common.js:419:15)
    at Socket.g (events.js:292:16)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at readableAddChunk (_stream_readable.js:176:18)
    at Socket.Readable.push (_stream_readable.js:134:10)
    at Pipe.onread (net.js:551:20)

@santigimeno
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/5452/

@santigimeno
test: fix flaky test-debug-port
793d871 
It can happen that first data chunk received in stdout is not exactly
`'debug> '`. Make sure the exit condition is met.

PR-URL: nodejs#10316
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
@santigimeno santigimeno merged commit 793d871 into nodejs:master Dec 19, 2016
@santigimeno santigimeno deleted the fix_flaky_debug branch December 19, 2016 19:03
@santigimeno
Copy link
Member Author

Thanks! Landed in 793d871

cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 20, 2016
@santigimeno @cjihrig
test: fix flaky test-debug-port
88086ce 
It can happen that first data chunk received in stdout is not exactly
`'debug> '`. Make sure the exit condition is met.

PR-URL: nodejs#10316
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
@italoacasas italoacasas mentioned this pull request Dec 20, 2016
Merged
cjihrig pushed a commit that referenced this pull request Dec 20, 2016
@santigimeno @cjihrig
test: fix flaky test-debug-port
2fbb998 
It can happen that first data chunk received in stdout is not exactly
`'debug> '`. Make sure the exit condition is met.

PR-URL: #10316
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@italoacasas italoacasas italoacasas approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@santigimeno @lpinca @cjihrig @italoacasas @mscdex @MylesBorins @nodejs-github-bot