Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor the code in test-fs-watch.js #10357

Closed
wants to merge 1 commit into from
Closed

test: refactor the code in test-fs-watch.js #10357

wants to merge 1 commit into from

Conversation

sivaprs
Copy link
Contributor

@sivaprs sivaprs commented Dec 20, 2016 •
edited
Loading

  • used let and const instead of var
  • used assert.strictEqual instead assert.equal
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

used let and const instead of var
used assert.strictEqual instead of assert.equal

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Dec 20, 2016
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Dec 20, 2016
@julianduque
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-commit/6745/

@sivaprs
test: refactor the code in test-fs-watch.js
4d4e53c 
* used let and const instead of var
* used assert.strictEqual instead assert.equal
@sivaprs
Copy link
Contributor Author

sivaprs commented Dec 21, 2016

cc @thefourtheye

thefourtheye
thefourtheye approved these changes Dec 21, 2016
View reviewed changes
Copy link
Contributor

@thefourtheye thefourtheye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI Run: https://ci.nodejs.org/job/node-test-pull-request/5507/

Good job Siva!

jasnell pushed a commit that referenced this pull request Dec 23, 2016
@sivaprs @jasnell
test: refactor the code in test-fs-watch.js
5b82800 
* used let and const instead of var
* used assert.strictEqual instead assert.equal

PR-URL: #10357
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Dec 23, 2016

Landed in 5b82800

@jasnell jasnell closed this Dec 23, 2016
@thefourtheye
Copy link
Contributor

Congratulations on your first contribution, Siva :-)

italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@sivaprs @italoacasas
test: refactor the code in test-fs-watch.js
2980325 
* used let and const instead of var
* used assert.strictEqual instead assert.equal

PR-URL: nodejs#10357
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 19, 2017
@sivaprs @italoacasas
test: refactor the code in test-fs-watch.js
b8720a0 
* used let and const instead of var
* used assert.strictEqual instead assert.equal

PR-URL: nodejs#10357
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
@sivaprs @italoacasas
test: refactor the code in test-fs-watch.js
1a1564f 
* used let and const instead of var
* used assert.strictEqual instead assert.equal

PR-URL: nodejs#10357
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@sivaprs @italoacasas
test: refactor the code in test-fs-watch.js
2ad8496 
* used let and const instead of var
* used assert.strictEqual instead assert.equal

PR-URL: nodejs#10357
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@sivaprs @italoacasas
test: refactor the code in test-fs-watch.js
94a266e 
* used let and const instead of var
* used assert.strictEqual instead assert.equal

PR-URL: nodejs#10357
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@sivaprs @italoacasas
test: refactor the code in test-fs-watch.js
711b8ef 
* used let and const instead of var
* used assert.strictEqual instead assert.equal

PR-URL: nodejs#10357
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@sivaprs @MylesBorins
test: refactor the code in test-fs-watch.js
97167f1 
* used let and const instead of var
* used assert.strictEqual instead assert.equal

PR-URL: #10357
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@sivaprs @MylesBorins
test: refactor the code in test-fs-watch.js
99a234c 
* used let and const instead of var
* used assert.strictEqual instead assert.equal

PR-URL: #10357
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@santigimeno santigimeno santigimeno approved these changes

@julianduque julianduque julianduque approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sivaprs @julianduque @jasnell @thefourtheye @santigimeno @cjihrig @mscdex @MylesBorins @nodejs-github-bot