src: remove unused PROTOCOL_JSON array #10407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
santigimeno
approved these changes
Dec 22, 2016
cjihrig
approved these changes
Dec 22, 2016
jasnell
approved these changes
Dec 23, 2016
Overlooked when moving code around in commit 42da740 ("inspector: split HTTP/WS server from the inspector".) PR-URL: nodejs#10407 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
bnoordhuis
force-pushed
the
remove-unused-array
branch
from
b0e50fa to
77be180
Compare
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
Overlooked when moving code around in commit 42da740 ("inspector: split HTTP/WS server from the inspector".) PR-URL: nodejs#10407 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
Overlooked when moving code around in commit 42da740 ("inspector: split HTTP/WS server from the inspector".) PR-URL: nodejs#10407 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
Overlooked when moving code around in commit 42da740 ("inspector: split HTTP/WS server from the inspector".) PR-URL: nodejs#10407 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
|
A backport PR would be required in order for this to land on v6 |
|
Not applicable to 6.x as it does not have inspector_socket_server.cc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overlooked when moving code around in commit 42da740 ("inspector: split
HTTP/WS server from the inspector".)
CI: https://ci.nodejs.org/job/node-test-pull-request/5530/