Fix trace warnings #10416
Merged
Fix trace warnings #10416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
jasnell
approved these changes
Dec 23, 2016
addaleax
approved these changes
Dec 25, 2016
cjihrig
approved these changes
Dec 26, 2016
Initialize `InternalTraceBuffer::id_` the last. PR-URL: nodejs#10416 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Remove `external_buffer_` from `InternalTraceBuffer` as it seems not to be used anywhere. PR-URL: nodejs#10416 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
santigimeno
force-pushed
the
fix_trace_warnings
branch
from
d36ea03 to
e69a696
Compare
This was referenced Jan 19, 2017
mscdex
added
the
trace_events
|
Marking don't land on v7.x since it depends on #9304. |
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 1, 2017
Initialize `InternalTraceBuffer::id_` the last. PR-URL: nodejs#10416 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 1, 2017
Remove `external_buffer_` from `InternalTraceBuffer` as it seems not to be used anywhere. PR-URL: nodejs#10416 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Mar 1, 2017
Initialize `InternalTraceBuffer::id_` the last. PR-URL: nodejs#10416 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Mar 1, 2017
Remove `external_buffer_` from `InternalTraceBuffer` as it seems not to be used anywhere. PR-URL: nodejs#10416 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
|
marking don't land on 4 and 6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tracing
Description of change
Fix -Wreorder warning and -Wunused-private-field warnings.
I've split the PR into 2 commits as I'm not sure about the second fix.