Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix linter error in whatwg-url-parsing #10421

Closed
wants to merge 1 commit into from
Closed

test: fix linter error in whatwg-url-parsing #10421

wants to merge 1 commit into from

Conversation

thefourtheye
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

test-whatwg-url-parsing file violates the linter rule changes in
966e5cf. This patch makes the linter
happy.

@thefourtheye
test: fix linter error in whatwg-url-parsing
48316f1 
test-whatwg-url-parsing file violates the linter rule changes in
966e5cf. This patch makes the linter
happy.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 23, 2016
@thefourtheye
Copy link
Contributor Author

cc @targos @jasnell @nodejs/collaborators

addaleax
addaleax approved these changes Dec 23, 2016
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to land it instantly

@thefourtheye
Copy link
Contributor Author

Thanks for the review @addaleax :-) Landed in 5acfbb0

@thefourtheye thefourtheye deleted the fix-linter-error branch December 23, 2016 05:51
thefourtheye added a commit that referenced this pull request Dec 23, 2016
@thefourtheye
test: fix linter error in whatwg-url-parsing
5acfbb0 
test-whatwg-url-parsing file violates the linter rule changes in
#10213. This patch makes the linter
happy.

PR-URL: #10421

Reviewed-By: Anna Henningsen <anna@addaleax.net>
@evanlucas evanlucas mentioned this pull request Jan 3, 2017
Merged
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
@thefourtheye @evanlucas
test: fix linter error in whatwg-url-parsing
456248d 
test-whatwg-url-parsing file violates the linter rule changes in
#10213. This patch makes the linter
happy.

PR-URL: #10421

Reviewed-By: Anna Henningsen <anna@addaleax.net>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
@thefourtheye @evanlucas
test: fix linter error in whatwg-url-parsing
9d0220c 
test-whatwg-url-parsing file violates the linter rule changes in
#10213. This patch makes the linter
happy.

PR-URL: #10421

Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Jan 23, 2017
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thefourtheye @addaleax @MylesBorins @nodejs-github-bot