Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: increase coverage of Buffer.transcode #10437

Closed
wants to merge 1 commit into from
Closed

test: increase coverage of Buffer.transcode #10437

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test, buffer

Description of change

Adds test for transcoding an empty buffer.

@joyeecheung
test: increase coverage of Buffer.transcode
8dd90e3 
Adds test for transcoding an empty buffer.
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Dec 24, 2016
@mscdex mscdex added the buffer Issues and PRs related to the buffer subsystem. label Dec 24, 2016
Trott
Trott approved these changes Dec 24, 2016
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green.

@Trott
Copy link
Member

Trott commented Dec 24, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5574/

evanlucas
evanlucas approved these changes Dec 24, 2016
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

jasnell pushed a commit that referenced this pull request Dec 24, 2016
@joyeecheung @jasnell
test: increase coverage of Buffer.transcode
904b66d 
Adds test for transcoding an empty buffer.

PR-URL: #10437
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Dec 24, 2016

Landed in 904b66d

@jasnell jasnell closed this Dec 24, 2016
@joyeecheung joyeecheung deleted the test-empty-transcode branch January 2, 2017 05:28
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@joyeecheung @italoacasas
test: increase coverage of Buffer.transcode
6020904 
Adds test for transcoding an empty buffer.

PR-URL: nodejs#10437
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jan 19, 2017
Closed
Closed
@jasnell jasnell mentioned this pull request Apr 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@Trott Trott Trott approved these changes

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@joyeecheung @Trott @jasnell @evanlucas @targos @cjihrig @mscdex @nodejs-github-bot