clarify the statement in vm.createContext() API #10519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
jasnell
approved these changes
Dec 29, 2016
princejwesley
approved these changes
Dec 29, 2016
fhinkel
approved these changes
Dec 31, 2016
fhinkel
pushed a commit
to fhinkel/node
that referenced
this pull request
Jan 4, 2017
PR-URL: nodejs#10519 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
|
Landed in c57caf5. Thanks! |
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
PR-URL: #10519 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
|
@fhinkel does this apply to v4.x or v6.x? |
|
Both. |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 7, 2017
PR-URL: #10519 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
PR-URL: #10519 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Clarifying the statement in
vm.createContext([])ofhttps://nodejs.org/api/vm.html
Outside of scripts run by the vm module, sandbox will remain unchanged.Sandbox does reflect the changes made within the vm module.
What remains unchanged are the global variables.
To avoid confusion, the statement could benefit from a re-write,
possibly with a code snippet to illustrate the point.