Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use const for all require() calls #10550

Merged
merged 1 commit into from
Jan 2, 2017
Merged

test: use const for all require() calls #10550

merged 1 commit into from
Jan 2, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 30, 2016

This commit assigns the results of every require() to a const variable. This follows the style used in /lib.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Dec 30, 2016
Trott
Trott approved these changes Dec 31, 2016
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHUUUUURRRRNNNN!!!! But that's fine by me in this case. LGTM if CI is ✅

@gibfahn
Copy link
Member

gibfahn commented Dec 31, 2016

CI: https://ci.nodejs.org/job/node-test-commit/6946/console

And there's already a merge conflict...

@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 1, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/5655/

@cjihrig
test: use const for all require() calls
ff1efa6 
PR-URL: nodejs#10550
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrig cjihrig merged commit ff1efa6 into nodejs:master Jan 2, 2017
@cjihrig cjihrig deleted the requires branch January 2, 2017 23:45
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@cjihrig @italoacasas
test: use const for all require() calls
45cf08c 
PR-URL: nodejs#10550
Reviewed-By: Rich Trott <rtrott@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 19, 2017
@cjihrig @italoacasas
test: use const for all require() calls
10abc52 
PR-URL: nodejs#10550
Reviewed-By: Rich Trott <rtrott@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
targos pushed a commit that referenced this pull request Jan 28, 2017
@cjihrig @targos
test: use const for all require() calls
e141f3f 
PR-URL: #10550
Reviewed-By: Rich Trott <rtrott@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@cjihrig @italoacasas
test: use const for all require() calls
dd9aefd 
PR-URL: nodejs#10550
Reviewed-By: Rich Trott <rtrott@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@cjihrig @italoacasas
test: use const for all require() calls
b7d726e 
PR-URL: nodejs#10550
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins
Copy link
Contributor

@cjihrig could you backport to v4 / v6?

@cjihrig
Copy link
Contributor Author

cjihrig commented Mar 11, 2017

This should get picked up by #11775 and #11773.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @gibfahn @MylesBorins @Trott @mscdex @addaleax @nodejs-github-bot