Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve test-event-emitter-modify-in-emit #10600

Closed
wants to merge 1 commit into from
Closed

test: improve test-event-emitter-modify-in-emit #10600

wants to merge 1 commit into from

Conversation

edsadr
Copy link
Member

@edsadr edsadr commented Jan 4, 2017

  • use let instead of var
  • use assert.strictEqual instead of assert.equal
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Jan 4, 2017
@mscdex mscdex added the events Issues and PRs related to the events subsystem / EventEmitter. label Jan 4, 2017
lpinca
lpinca reviewed Jan 6, 2017
View reviewed changes
test/parallel/test-event-emitter-modify-in-emit.js
@@ -25,35 +25,35 @@ function callback3() {
}

e.on('foo', callback1);
assert.equal(1, e.listeners('foo').length);
assert.strictEqual(1, e.listeners('foo').length);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you please swap the arguments?

@edsadr
test: improve test-event-emitter-modify-in-emit
35ef607 
* use let instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard
@edsadr edsadr force-pushed the event-emitter-modify branch from 7017afa to 35ef607 Compare January 6, 2017 17:52
@edsadr
Copy link
Member Author

edsadr commented Jan 6, 2017

@lpinca , did the nit

@lpinca
Copy link
Member

lpinca commented Jan 6, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/5731/

@lpinca
Copy link
Member

lpinca commented Jan 6, 2017

Landed in 75ebd19.

@lpinca lpinca closed this Jan 6, 2017
lpinca pushed a commit that referenced this pull request Jan 6, 2017
@edsadr @lpinca
test: improve test-event-emitter-modify-in-emit
75ebd19 
* use let instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: #10600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@edsadr @italoacasas
test: improve test-event-emitter-modify-in-emit
17c86ac 
* use let instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: nodejs#10600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 19, 2017
@edsadr @italoacasas
test: improve test-event-emitter-modify-in-emit
7032f81 
* use let instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: nodejs#10600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 24, 2017
@edsadr @italoacasas
test: improve test-event-emitter-modify-in-emit
e134247 
* use let instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: nodejs#10600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@edsadr @italoacasas
test: improve test-event-emitter-modify-in-emit
06a8243 
* use let instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: nodejs#10600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@edsadr @MylesBorins
test: improve test-event-emitter-modify-in-emit
9a99608 
* use let instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: #10600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@edsadr @MylesBorins
test: improve test-event-emitter-modify-in-emit
17a63e1 
* use let instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: #10600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
events Issues and PRs related to the events subsystem / EventEmitter. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@edsadr @lpinca @jasnell @cjihrig @mscdex @MylesBorins @nodejs-github-bot