Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: ensure host setter matches parse for file url #10615

Closed
wants to merge 2 commits into from
Closed

url: ensure host setter matches parse for file url #10615

wants to merge 2 commits into from

Commits on Apr 21, 2017

  1. url: ensure host setter matches parse for file url 

    Technically, file URLs are not permitted to have a port. There is
currently an ambiguity in the URL spec. In the current spec
having a port in a file URL is undefined behavior. In the current
implementation, the port is ignored and handled as if it were part
of the host name. This will be changing once the ambiguity is
resolved in the spec. The spec change may involve either ignoring the
port if specified or throwing with an Invalid URL error if the port
is specified. For now, this test verifies the currently implemented
behavior.

Fixes: nodejs#10608
    @jasnell
    jasnell committed Apr 21, 2017
    Configuration menu
    Copy the full SHA
    9d868c6 View commit details
    Browse the repository at this point in the history

  2. url: add file port tests to url test fixtures

    @jasnell
    jasnell committed Apr 21, 2017
    Configuration menu
    Copy the full SHA
    c8b2f55 View commit details
    Browse the repository at this point in the history