Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: specify sorted tests #10716

Merged
merged 0 commits into from
Jan 10, 2017
Merged

doc: specify sorted tests #10716

merged 0 commits into from
Jan 10, 2017
+0 −0

Conversation

sam-github
Copy link
Contributor

And allow anchor links to the various sections, to more easily reference
them when reviewing PRs.

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test,doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 9, 2017
@sam-github sam-github requested review from Trott and gibfahn January 9, 2017 20:37
@sam-github sam-github mentioned this pull request Jan 9, 2017
Merged
4 tasks
@mscdex mscdex added the test Issues and PRs related to the tests. label Jan 9, 2017
Trott
Trott approved these changes Jan 10, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gibfahn
gibfahn approved these changes Jan 10, 2017
View reviewed changes
Copy link
Member

@gibfahn gibfahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe sorted requires in tests rather than sorted tests (in the commit message)

@sam-github sam-github closed this Jan 10, 2017
@sam-github sam-github deleted the tests-sort-requires branch January 10, 2017 15:32
@sam-github sam-github merged commit 5aa210a into nodejs:master Jan 10, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@sam-github @italoacasas
doc: specify sorted requires in tests
73527d1 
And allow anchor links to the various sections, to more easily reference
them when reviewing PRs.

PR-URL: nodejs#10716
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
@sam-github @italoacasas
doc: specify sorted requires in tests
19e1220 
And allow anchor links to the various sections, to more easily reference
them when reviewing PRs.

PR-URL: nodejs#10716
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
@sam-github @italoacasas
doc: specify sorted requires in tests
27067c7 
And allow anchor links to the various sections, to more easily reference
them when reviewing PRs.

PR-URL: nodejs#10716
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@sam-github @italoacasas
doc: specify sorted requires in tests
09ac2a2 
And allow anchor links to the various sections, to more easily reference
them when reviewing PRs.

PR-URL: nodejs#10716
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@sam-github @MylesBorins
doc: specify sorted requires in tests
ea2973e 
And allow anchor links to the various sections, to more easily reference
them when reviewing PRs.

PR-URL: #10716
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@sam-github @MylesBorins
doc: specify sorted requires in tests
fa8a394 
And allow anchor links to the various sections, to more easily reference
them when reviewing PRs.

PR-URL: #10716
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sam-github @jasnell @Trott @lpinca @cjihrig @gibfahn @mscdex @MylesBorins @nodejs-github-bot