Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify memory sharing behavior of buffer ctor #10778

Closed
wants to merge 1 commit into from
Closed

doc: clarify memory sharing behavior of buffer ctor #10778

wants to merge 1 commit into from

Conversation

zbjornson
Copy link
Contributor

  • Clarify that memory is always shared and never copied.
  • Fix wording that sounded like ArrayBuffer has a buffer property.

Fixes #10770

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

docs (buffer)

@zbjornson
doc: clarify memory sharing behavior of buffer ctor
214471c 
* Clarify that memory is always shared and never copied.
* Fix wording that sounded like ArrayBuffer has a buffer property.

Fixes nodejs#10770
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. lts-watch-v6.x labels Jan 13, 2017
@italoacasas
Copy link
Contributor

Landed 5ab910e

italoacasas pushed a commit that referenced this pull request Jan 16, 2017
@zbjornson @italoacasas
doc: clarify memory sharing behavior of buffer ctor
5ab910e 
* Clarify that memory is always shared and never copied.
* Fix wording that sounded like ArrayBuffer has a buffer property.

PR-URL: #10778
Ref: #10770
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@zbjornson zbjornson deleted the 10770-arraybuff-docs branch January 16, 2017 21:40
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@zbjornson @italoacasas
doc: clarify memory sharing behavior of buffer ctor
90c8204 
* Clarify that memory is always shared and never copied.
* Fix wording that sounded like ArrayBuffer has a buffer property.

PR-URL: nodejs#10778
Ref: nodejs#10770
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
@zbjornson @italoacasas
doc: clarify memory sharing behavior of buffer ctor
3735682 
* Clarify that memory is always shared and never copied.
* Fix wording that sounded like ArrayBuffer has a buffer property.

PR-URL: nodejs#10778
Ref: nodejs#10770
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 24, 2017
@zbjornson @italoacasas
doc: clarify memory sharing behavior of buffer ctor
3a58d43 
* Clarify that memory is always shared and never copied.
* Fix wording that sounded like ArrayBuffer has a buffer property.

PR-URL: nodejs#10778
Ref: nodejs#10770
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@zbjornson @italoacasas
doc: clarify memory sharing behavior of buffer ctor
73939ec 
* Clarify that memory is always shared and never copied.
* Fix wording that sounded like ArrayBuffer has a buffer property.

PR-URL: nodejs#10778
Ref: nodejs#10770
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
@MylesBorins
Copy link
Contributor

Should this be backported?

@zbjornson
Copy link
Contributor Author

zbjornson commented Mar 14, 2017 •
edited
Loading

@MylesBorins it would correctly describe v6 if backported, so seems like it should be (although I don't know the backporting policy). v4.x has clear language; the unclear language was introduced in ac57089 (which was not backported).

MylesBorins pushed a commit that referenced this pull request Apr 13, 2017
@zbjornson @MylesBorins
doc: clarify memory sharing behavior of buffer ctor
a6ab9f2 
* Clarify that memory is always shared and never copied.
* Fix wording that sounded like ArrayBuffer has a buffer property.

PR-URL: #10778
Ref: #10770
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@zbjornson @MylesBorins
doc: clarify memory sharing behavior of buffer ctor
4fd765e 
* Clarify that memory is always shared and never copied.
* Fix wording that sounded like ArrayBuffer has a buffer property.

PR-URL: #10778
Ref: #10770
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@zbjornson @andrew749
doc: clarify memory sharing behavior of buffer ctor
71f2519 
* Clarify that memory is always shared and never copied.
* Fix wording that sounded like ArrayBuffer has a buffer property.

PR-URL: nodejs/node#10778
Ref: nodejs/node#10770
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zbjornson @italoacasas @MylesBorins @jasnell @lpinca @nodejs-github-bot