test: Use common.hasIntl in tests related to ICU
#10841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
reviewed
Jan 16, 2017
| if (!process.binding('config').hasIntl) { | ||
| common.skip('missing intl... skipping test'); | ||
| if (!common.hasIntl) { | ||
| common.skip('missing Intl... skipping test'); |
There was a problem hiding this comment.
Could you make the message just missing Intl please.
There was a problem hiding this comment.
Sure thing! I will update the following tests then:
$ grep -ir 'missing Intl...' test/parallel/
test/parallel//test-icu-punycode.js: common.skip('missing Intl... skipping test');
test/parallel//test-icu-stringwidth.js: common.skip('missing Intl... skipping test');
test/parallel//test-whatwg-url-parsing.js: common.skip('missing Intl... skipping test');
test/parallel//test-whatwg-url-setters.js: common.skip('missing Intl... skipping test');
We should use `common.hasIntl` in tests for test cases which are related to ICU. This way we can easily find the test cases that are Intl dependent. Plus, it will be able to make the tests a little faster if we check hasIntl first. Also, this tweaks the log messages to unify the message. Refs: nodejs#10707
watilde
force-pushed
the
feature/hasIntl
branch
from
2f1fab9 to
73b5335
Compare
mscdex
reviewed
Jan 16, 2017
| const common = require('../common'); | ||
| const assert = require('assert'); | ||
| const readline = require('internal/readline'); |
There was a problem hiding this comment.
I think we should keep all of the require()s together where possible.
There was a problem hiding this comment.
@mscdex If I'm not wrong, we are doing the same for crypto, where we require the additional modules only if common.hasCrypto is true.
addaleax
approved these changes
Jan 17, 2017
jasnell
approved these changes
Jan 17, 2017
cjihrig
approved these changes
Jan 17, 2017
lpinca
approved these changes
Jan 17, 2017
|
Landed in 71650aa. |
lpinca
pushed a commit
that referenced
this pull request
Jan 19, 2017
We should use `common.hasIntl` in tests for test cases which are related to ICU. This way we can easily find the test cases that are Intl dependent. Plus, it will be able to make the tests a little faster if we check hasIntl first. Also, this tweaks the log messages to unify the message. Refs: #10707 PR-URL: #10841 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 25, 2017
We should use `common.hasIntl` in tests for test cases which are related to ICU. This way we can easily find the test cases that are Intl dependent. Plus, it will be able to make the tests a little faster if we check hasIntl first. Also, this tweaks the log messages to unify the message. Refs: nodejs#10707 PR-URL: nodejs#10841 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
We should use `common.hasIntl` in tests for test cases which are related to ICU. This way we can easily find the test cases that are Intl dependent. Plus, it will be able to make the tests a little faster if we check hasIntl first. Also, this tweaks the log messages to unify the message. Refs: nodejs#10707 PR-URL: nodejs#10841 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
|
This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should use
common.hasIntlin tests for test cases which are related to ICU. This way we can easily find the test cases that are Intl dependent. Plus, it will be able to make the tests a little faster if we checkhasIntlfirst.Refs: #10707 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)