-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: backport 7c3748a from upstream V8 #10873
deps: backport 7c3748a from upstream V8 #10873
Conversation
cc @ofrobots |
@cristiancavalli I think the fix is also needed on |
@ofrobots yep, packaging it up as this message submits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but the commit hash in the status line is wrong (should be 7c3748a, not 2bd7464.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber stamp LGTM
a7a548c
to
f90cf95
Compare
commit message fixed |
@nodejs/build are we not keeping CI results for at least 10 days? new ci: https://ci.nodejs.org/job/node-test-pull-request/6020/ v8: https://ci.nodejs.org/job/node-test-commit-v8-linux/537/ |
Seeing failures for the V8 tests. Running tests again on v4.x-staging to ensure there isn't a regression on the staging branch |
f90cf95
to
935aefc
Compare
Added |
@ofrobots ... there's red in that CI. |
Running the |
This is failing because @cristiancavalli 's branch is missing #10732. @cristiancavalli can you rebase this onto (No wonder I had this very strong déjà vu when looking at the test) |
Original commit message: [debug] load correct stack slot for frame details. R=bmeurer@chromium.org BUG=v8:5071 Review URL: https://codereview.chromium.org/2045863002 . Cr-Commit-Position: refs/heads/master@{nodejs#36769} Signed-off-by: Cristian Cavalli <cristiancavall@google.com>
935aefc
to
6f5c421
Compare
@ofrobots Thanks for the find; updated accordingly |
My bad on targeting the wrong branch initially |
CI is green this time! Will land. |
Original commit message: [debug] load correct stack slot for frame details. R=bmeurer@chromium.org BUG=v8:5071 Review URL: https://codereview.chromium.org/2045863002 . Cr-Commit-Position: refs/heads/master@{#36769} PR-URL: #10873 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: ofrobots - Ali Ijaz Sheikh <ofrobots@google.com>
Landed on |
Original commit message: [debug] load correct stack slot for frame details. R=bmeurer@chromium.org BUG=v8:5071 Review URL: https://codereview.chromium.org/2045863002 . Cr-Commit-Position: refs/heads/master@{#36769} PR-URL: #10873 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: ofrobots - Ali Ijaz Sheikh <ofrobots@google.com>
Original commit message: [debug] load correct stack slot for frame details. R=bmeurer@chromium.org BUG=v8:5071 Review URL: https://codereview.chromium.org/2045863002 . Cr-Commit-Position: refs/heads/master@{#36769} PR-URL: #10873 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: ofrobots - Ali Ijaz Sheikh <ofrobots@google.com>
Original commit message: [debug] load correct stack slot for frame details. R=bmeurer@chromium.org BUG=v8:5071 Review URL: https://codereview.chromium.org/2045863002 . Cr-Commit-Position: refs/heads/master@{#36769} PR-URL: nodejs/node#10873 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: ofrobots - Ali Ijaz Sheikh <ofrobots@google.com>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
deps
V8 Commit:
v8/v8@7c3748a
Description of change
Backport of bugfix from upstream V8
Original commit message:
[debug] load correct stack slot for frame details.
R=bmeurer@chromium.org
BUG=v8:5071
Review URL: https://codereview.chromium.org/2045863002 .
Cr-Commit-Position: refs/heads/master@{#36769}