test: verify shell option internals #10924
Merged
+56
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
test
mscdex
added
the
child_process
This commit adds code coverage to the internals associated with the child_process shell option. This achieves the following: - Increased code coverage, which is currently only reported for Unix. - Ensures that all six code paths are covered, including the three Windows variations, and Android which is not tested at all on CI. PR-URL: nodejs#10924 Reviewed-By: Rich Trott <rtrott@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 25, 2017
This commit adds code coverage to the internals associated with the child_process shell option. This achieves the following: - Increased code coverage, which is currently only reported for Unix. - Ensures that all six code paths are covered, including the three Windows variations, and Android which is not tested at all on CI. PR-URL: nodejs#10924 Reviewed-By: Rich Trott <rtrott@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
This commit adds code coverage to the internals associated with the child_process shell option. This achieves the following: - Increased code coverage, which is currently only reported for Unix. - Ensures that all six code paths are covered, including the three Windows variations, and Android which is not tested at all on CI. PR-URL: nodejs#10924 Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
This commit adds code coverage to the internals associated with the child_process shell option. This achieves the following: - Increased code coverage, which is currently only reported for Unix. - Ensures that all six code paths are covered, including the three Windows variations, and Android which is not tested at all on CI. PR-URL: nodejs#10924 Reviewed-By: Rich Trott <rtrott@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
This commit adds code coverage to the internals associated with the child_process shell option. This achieves the following: - Increased code coverage, which is currently only reported for Unix. - Ensures that all six code paths are covered, including the three Windows variations, and Android which is not tested at all on CI. PR-URL: nodejs#10924 Reviewed-By: Rich Trott <rtrott@gmail.com>
|
This is failing on v6 and uses features not available in v4 Please lmk if we should chase down the failure in v6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds code coverage to the internals associated with
the child_process shell option. This achieves the following:
for Unix.
three Windows variations, and Android which is not tested at
all on CI.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test
CI: https://ci.nodejs.org/job/node-test-pull-request/5999/
CI: https://ci.nodejs.org/job/node-test-pull-request/6001/