Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add version meta for SSL_CERT_DIR/FILE #11007

Merged
merged 1 commit into from
Feb 20, 2017
Merged

doc: add version meta for SSL_CERT_DIR/FILE #11007

merged 1 commit into from
Feb 20, 2017

Conversation

sam-github
Copy link
Contributor

The metadata markup for when SSL_CERT_DIR and SSL_CERT_FILE added in
33012e9 is missing.

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. dont-land-on-v7.x labels Jan 25, 2017
@sam-github
Copy link
Contributor Author

Who fills in the FIXME values? Does that happen automatically, or should I fill it in based on when I expect them to be released in 7.x?

evanlucas
evanlucas suggested changes Jan 25, 2017
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will be updated in the release commit along with the changelog update by the releaser.

doc/api/cli.md Outdated
@@ -378,6 +378,9 @@ Note that neither the well known nor extra certificates are used when the `ca`
options property is explicitly specified for a TLS or HTTPS client or server.

### `SSL_CERT_DIR=dir`
<!-- YAML
added: FIXME
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added: REPLACEME

doc/api/cli.md Outdated
@@ -387,6 +390,9 @@ evironment variable will be inherited by any child processes, and if they use
OpenSSL, it may cause them to trust the same CAs as node.

### `SSL_CERT_FILE=file`
<!-- YAML
added: FIXME
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added: REPLACEME

@sam-github
Copy link
Contributor Author

Thanks Evan, fixed the markup, PTAL

@mscdex mscdex added tls Issues and PRs related to the tls subsystem. and removed dont-land-on-v7.x labels Jan 25, 2017
@sam-github
Copy link
Contributor Author

@evanlucas nudge, PTAL

evanlucas
evanlucas approved these changes Feb 20, 2017
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry I had forgotten about this one :]

Thanks!

@sam-github
Copy link
Contributor Author

I forgot, too, thanks for the review.

@sam-github
doc: add version meta for SSL_CERT_DIR/FILE
d2de2ad 
The metadata markup for when SSL_CERT_DIR and SSL_CERT_FILE added in
33012e9 is missing.

PR-URL: nodejs#11007
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@sam-github sam-github merged commit d2de2ad into nodejs:master Feb 20, 2017
@sam-github sam-github deleted the markup-ssl-conf-added-meta branch February 20, 2017 15:33
@sam-github
Copy link
Contributor Author

@italoacasas low risk doc-only fixup for 7.x if there is still time

@italoacasas
Copy link
Contributor

@sam-github I already freeze the proposal since the release is tomorrow. This should be part of 7.7.0 (Feb 28).

@sam-github
Copy link
Contributor Author

@italoacasas no problem, thanks for looking

addaleax pushed a commit that referenced this pull request Feb 22, 2017
@sam-github @addaleax
doc: add version meta for SSL_CERT_DIR/FILE
20d86db 
The metadata markup for when SSL_CERT_DIR and SSL_CERT_FILE added in
33012e9 is missing.

PR-URL: #11007
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 25, 2017
Merged
@jasnell
Copy link
Member

jasnell commented Mar 7, 2017

this would need a backport PR to land in v4 or v6

@sam-github
Copy link
Contributor Author

I don't think it needs backporting, it will likely land clean if the PR it fixes up lands: #8334 (which does need backporting)

@sam-github sam-github mentioned this pull request Mar 10, 2017
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@evanlucas evanlucas evanlucas approved these changes

Assignees
No one assigned
Labels
cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sam-github @italoacasas @jasnell @evanlucas @mscdex @nodejs-github-bot