Update module.js

[earforth]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

[mscdex]

I'm not convinced we should start removing try-catch/try-finally helper functions just yet. node v7 was the first branch to have a version of V8 that allowed for optimization of functions containing such statements and even then the functions containing these statements are currently not inlineable.

[earforth]

I'm not removing try-catch/try-finally , I just adjust the sequence to delete the "threw"

[earforth]

just like this
try {
module.load(filename);
Module._cache[filename] = module;
} finally {
}

return module.exports;

[mscdex]

You're removing the helper function (tryModuleLoad()) which helps isolate the effects of having try-catch/try-finally in a function.

[earforth]

In v4.x, there is no function tryModuleLoad

[mscdex]

The reason it's not in v4.x is because that particular change didn't get backported (due to waiting for the changes to sit for awhile in non-LTS branches). It does exist in v6.x, v7.x, and master however.

[bnoordhuis]

@earforth What is the motivation for this change? We don't usually accept aesthetic-only changes.

[jasnell]

I think I'm -1 on this one. The code here is very sensitive to breakage and this does not appear to deliver enough benefit.